IDL roll to multivm 1266

IDL roll to multivm 1266

TBR=blois

Committed: 23517

[vsm, 2013-06-02 22:49:00]

Committed patchset #1 manually as r23517 (presubmit successful).

[antonm1, 2013-06-03 08:51:22]

DB{C,Q}

https://codereview.appspot.com/9889044/diff/1/core/dom/NodeList.idl
File core/dom/NodeList.idl (right):

https://codereview.appspot.com/9889044/diff/1/core/dom/NodeList.idl#newcode27
core/dom/NodeList.idl:27: [ImplementedAs=anonymousNamedGetter, OverrideBuiltins]
getter (Node or unsigned long) (DOMString name);
wow!  I wonder how we process those.

https://codereview.appspot.com/9889044/diff/1/core/html/FormData.idl
File core/html/FormData.idl (left):

https://codereview.appspot.com/9889044/diff/1/core/html/FormData.idl#oldcode35
core/html/FormData.idl:35: ] interface DOMFormData {
there are still some references to DOMFormData in dom.json, should those go
away?

https://codereview.appspot.com/9889044/diff/1/core/html/MediaKeyError.idl
File core/html/MediaKeyError.idl (left):

https://codereview.appspot.com/9889044/diff/1/core/html/MediaKeyError.idl#old...
core/html/MediaKeyError.idl:27: Conditional=ENCRYPTED_MEDIA|ENCRYPTED_MEDIA_V2,
ENCRYPTED_MEDIA_V2 define, cannot it go away now?

https://codereview.appspot.com/9889044/diff/1/core/html/URL.idl
File core/html/URL.idl (left):

https://codereview.appspot.com/9889044/diff/1/core/html/URL.idl#oldcode31
core/html/URL.idl:31: ] interface DOMURL {
ditto for dom.json

https://codereview.appspot.com/9889044/diff/1/core/html/canvas/Path.idl
File core/html/canvas/Path.idl (left):

https://codereview.appspot.com/9889044/diff/1/core/html/canvas/Path.idl#oldco...
core/html/canvas/Path.idl:37: ] interface DOMPath {
ditto for DOMPath in dom.json and all other renames

https://codereview.appspot.com/9889044/diff/1/core/page/Location.idl
File core/page/Location.idl (right):

https://codereview.appspot.com/9889044/diff/1/core/page/Location.idl#newcode32
core/page/Location.idl:32: [SetterCallWith=ActiveWindow|FirstWindow,
DoNotCheckSecurityOnSetter, Unforgeable] attribute DOMString href;
do you know how those changes affect generated native bindings?

[vsm, 2013-06-03 14:37:50]

On 2013/06/03 08:51:22, antonm1 wrote:
> DB{C,Q}
> 
> https://codereview.appspot.com/9889044/diff/1/core/dom/NodeList.idl
> File core/dom/NodeList.idl (right):
> 
> https://codereview.appspot.com/9889044/diff/1/core/dom/NodeList.idl#newcode27
> core/dom/NodeList.idl:27: [ImplementedAs=anonymousNamedGetter,
OverrideBuiltins]
> getter (Node or unsigned long) (DOMString name);
> wow!  I wonder how we process those.

Yeah.  I added a UnionType to the parser.  We should map it to dynamic for now. 
I haven't had to do this yet surprisingly.  I believe all these methods are
dropped right now - they are all named indexed getters.

> 
> https://codereview.appspot.com/9889044/diff/1/core/html/FormData.idl
> File core/html/FormData.idl (left):
> 
> https://codereview.appspot.com/9889044/diff/1/core/html/FormData.idl#oldcode35
> core/html/FormData.idl:35: ] interface DOMFormData {
> there are still some references to DOMFormData in dom.json, should those go
> away?

I'll take a look.

> 
> https://codereview.appspot.com/9889044/diff/1/core/html/MediaKeyError.idl
> File core/html/MediaKeyError.idl (left):
> 
>
https://codereview.appspot.com/9889044/diff/1/core/html/MediaKeyError.idl#old...
> core/html/MediaKeyError.idl:27:
Conditional=ENCRYPTED_MEDIA|ENCRYPTED_MEDIA_V2,
> ENCRYPTED_MEDIA_V2 define, cannot it go away now?

It shows up a few lines below in this file.
> 
> https://codereview.appspot.com/9889044/diff/1/core/html/URL.idl
> File core/html/URL.idl (left):
> 
> https://codereview.appspot.com/9889044/diff/1/core/html/URL.idl#oldcode31
> core/html/URL.idl:31: ] interface DOMURL {
> ditto for dom.json
> 
> https://codereview.appspot.com/9889044/diff/1/core/html/canvas/Path.idl
> File core/html/canvas/Path.idl (left):
> 
>
https://codereview.appspot.com/9889044/diff/1/core/html/canvas/Path.idl#oldco...
> core/html/canvas/Path.idl:37: ] interface DOMPath {
> ditto for DOMPath in dom.json and all other renames
> 
> https://codereview.appspot.com/9889044/diff/1/core/page/Location.idl
> File core/page/Location.idl (right):
> 
> https://codereview.appspot.com/9889044/diff/1/core/page/Location.idl#newcode32
> core/page/Location.idl:32: [SetterCallWith=ActiveWindow|FirstWindow,
> DoNotCheckSecurityOnSetter, Unforgeable] attribute DOMString href;
> do you know how those changes affect generated native bindings?

I had to keep these all custom (they're auto-generated in V8).  We don't process
ActiveWindow or FirstWindow.  We need to inject window as an argument for each
to automate this.