code review 988043: net: fix bug in internetSocket introduced by error cleanup.

net: fix bug in internetSocket introduced by error cleanup.

Fixes issue 750.

[rsc, 2010-04-27 20:13:42]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-04-27 23:39:03]

LGTM

On 28 Apr 2010 06:13, <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> net: fix bug in internetSocket introduced by error cleanup.
>
> Fixes issue 750.
>
> Please review this at http://codereview.appspot.com/988043/show
>
> Affected files:
> M src/pkg/net/ipsock.go
>
>
> Index: src/pkg/net/ipsock.go
> ===================================================================
> --- a/src/pkg/net/ipsock.go
> +++ b/src/pkg/net/ipsock.go
> @@ -78,7 +78,7 @@
> }
> }
> fd, oserr = socket(net, family, proto, 0, la, ra, toAddr)
> - if err != nil {
> + if oserr != nil {
> goto Error
> }
> return fd, nil
>
>

[rsc, 2010-04-28 01:48:14]

*** Submitted as http://code.google.com/p/go/source/detail?r=4d8375cad663 ***

net: fix bug in internetSocket introduced by error cleanup.

Fixes issue 750.

R=adg
CC=golang-dev
http://codereview.appspot.com/988043