Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 9866043: Simplified TType class by carving out TStructure and TField. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Alok Priyadarshi
Modified:
10 years, 9 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Simplified TType class by carving out TStructure and TField. R=kbr@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=2423

Patch Set 1 #

Patch Set 2 : renamed TStructure::size to objectSize #

Patch Set 3 : reverted glslang_lex.cpp #

Total comments: 10

Patch Set 4 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -355 lines) Patch
M src/compiler/Intermediate.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M src/compiler/OutputGLSLBase.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/OutputGLSLBase.cpp View 1 2 3 6 chunks +47 lines, -30 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 10 chunks +30 lines, -26 lines 0 comments Download
M src/compiler/ParseHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ParseHelper.cpp View 1 7 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 1 4 chunks +42 lines, -64 lines 0 comments Download
M src/compiler/Types.h View 1 5 chunks +89 lines, -52 lines 0 comments Download
M src/compiler/VariableInfo.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/compiler/glslang.y View 10 chunks +56 lines, -65 lines 0 comments Download
M src/compiler/glslang_tab.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 12 chunks +78 lines, -87 lines 0 comments Download

Messages

Total messages: 6
Alok Priyadarshi
No functional change. Just removing unnecessary cruft from TType.
10 years, 10 months ago (2013-05-30 20:15:20 UTC) #1
kbr1
https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp File src/compiler/OutputGLSLBase.cpp (left): https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp#oldcode264 src/compiler/OutputGLSLBase.cpp:264: // TODO(alokp): ASSERT What happened to this TODO? https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp ...
10 years, 10 months ago (2013-06-04 19:06:41 UTC) #2
Alok Priyadarshi
https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp File src/compiler/OutputGLSLBase.cpp (left): https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp#oldcode264 src/compiler/OutputGLSLBase.cpp:264: // TODO(alokp): ASSERT On 2013/06/04 19:06:41, kbr1 wrote: > ...
10 years, 9 months ago (2013-06-05 21:43:18 UTC) #3
kbr1
LGTM https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp File src/compiler/OutputGLSLBase.cpp (right): https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp#newcode251 src/compiler/OutputGLSLBase.cpp:251: const TField* field = structure->fields()[index->getIConst(0)]; On 2013/06/05 21:43:18, ...
10 years, 9 months ago (2013-06-05 23:57:09 UTC) #4
Alok Priyadarshi
https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp File src/compiler/OutputGLSLBase.cpp (right): https://codereview.appspot.com/9866043/diff/4001/src/compiler/OutputGLSLBase.cpp#newcode251 src/compiler/OutputGLSLBase.cpp:251: const TField* field = structure->fields()[index->getIConst(0)]; On 2013/06/05 23:57:10, kbr1 ...
10 years, 9 months ago (2013-06-06 16:21:06 UTC) #5
Alok Priyadarshi
10 years, 9 months ago (2013-06-06 16:25:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r2423 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b