code review 9858043: runtime: avoid adding garbage collector's own stack fra...

runtime: avoid adding garbage collector's own stack frames as roots

Binary values stored in stack frames of C functions in mgc0.c
may prevent the garbage collector from freeing large objects.

Update issue 5584

[atom, 2013-05-29 16:49:39]

Hello golang-dev@googlegroups.com (cc: dvyukov, rsc, cshapiro),

I'd like you to review this change to
https://code.google.com/p/go/

[atom, 2013-05-29 16:52:30]

https://codereview.appspot.com/9858043/diff/1/src/pkg/runtime/mgc0.c
File src/pkg/runtime/mgc0.c (right):

https://codereview.appspot.com/9858043/diff/1/src/pkg/runtime/mgc0.c#newcode1445
src/pkg/runtime/mgc0.c:1445: 
Maybe it would be better to rename 'initsp' to 'ownsp'.

[cshapiro1, 2013-05-30 00:36:21]

(Unfortunately, I am getting an error when trying to view the side-by-side
diffs.  I am curious if others have the same problem)

The effect of this change should be achieved by 9754044 by running gc and its
callees on the scheduler stack.

What do you think?

[dave_cheney.net, 2013-05-30 00:37:21]

Confirmed, this is our constant friend,

error: old chunk mismatch

On Thu, May 30, 2013 at 10:36 AM,  <cshapiro@google.com> wrote:
> (Unfortunately, I am getting an error when trying to view the
> side-by-side diffs.  I am curious if others have the same problem)
>
> The effect of this change should be achieved by 9754044 by running gc
> and its callees on the scheduler stack.
>
> What do you think?
>
>
> https://codereview.appspot.com/9858043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[atom, 2013-05-30 07:06:09]

On 2013/05/30 00:36:21, cshapiro1 wrote:
> The effect of this change should be achieved by 9754044 by running gc and its
> callees on the scheduler stack.

Yes.

[rsc, 2013-06-03 20:16:14]

Removing reviewers.