Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 9854046: chrome testing fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by felix8a
Modified:
12 years, 10 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. Starting with Chrome 29 (canary), chromedriver no longer works. Instead we need chromedriver2 (which also works with earlier Chromes). 2. Chromedriver2 no longer supports the old way of setting Chrome options with capability names like "chrome.binary". We need to use the ChromeOptions object. 3. This adds a new flag test.chrome.args which lets you specify a semicolon-separated list of command-line args for Chrome. In particular "--js-flags=--harmony" will turn on experimental js features. (Note, if you look at about:flags, "experimental js" will show as off. The "experimental js" flag causes Chrome to pass --harmony to the js engine, and it doesn't reflect the current state of the js engine. There isn't a command-line arg that will set the "experimental js" flag itself.) 4. I'm updating selenium to the latest 2.33 for no reason, it's not relevant to any of the Chrome problems. (The jar isn't in this CL because codereview gets confused by the large binary file.) I'll update the wiki page on testing after committing this.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M build.xml View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/WebDriverHandle.java View 4 chunks +28 lines, -9 lines 0 comments Download
M tests/com/google/caja/util/TestFlag.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 10 months ago (2013-05-30 00:13:15 UTC) #1
kpreid2
LGTM
12 years, 10 months ago (2013-05-30 01:06:40 UTC) #2
felix8a
12 years, 10 months ago (2013-05-30 06:10:14 UTC) #3
@r5429
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b