Issue 98510043: Move osenv.(Set)Home functions to utils.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by frankban

Modified:
10 years, 12 months ago

Reviewers:
mp+220811, fwereade, rog

Visibility:
Public.

Description

Move osenv.(Set)Home functions to utils. This is an incremental step towards the goal to remove the osenv dependency from utils. https://code.launchpad.net/~frankban/juju-core/osenv-home/+merge/220811 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move osenv.(Set)Home functions to utils. #

Patch Set 3 : Move osenv.(Set)Home functions to utils. #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -64 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/filevar_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/deploy_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/config/authkeys.go	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	environs/config/authkeys_test.go	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/filestorage/filestorage_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	juju/osenv/home.go	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	juju/osenv/package_test.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	juju/testing/conn.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	provider/ec2/config_test.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	provider/local/config_test.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	testing/base.go	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	testing/base_test.go	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	testing/environ_test.go	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	utils/file.go	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	utils/file_test.go	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	utils/fslock/package_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/home_unix.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	utils/home_unix_test.go	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	utils/home_windows.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/home_windows_test.go	View		1 chunk	+13 lines, -7 lines	0 comments	Download
A	utils/package_test.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

LGTM modulo the below. https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { ...

10 years, 12 months ago (2014-05-23 16:49:06 UTC) #2

fwereade

https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { On 2014/05/23 16:49:06, rog ...

10 years, 12 months ago (2014-05-26 07:35:38 UTC) #3

frankban

Please take a look. https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { ...

10 years, 12 months ago (2014-05-26 08:51:55 UTC) #4

Please take a look.

Expand All Messages | Collapse All Messages