Issue 9831044: 3 cleanups in Domado.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9831044: 3 cleanups in Domado. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by kpreid2

Modified:
12 years, 10 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Per previous discussion at <https://codereview.appspot.com/9447044/>. * Remove 3-arg Props.cond and replace its use with ordinary a?b:c. * Rename Props.rename to Props.actAs. * Remove unused "CSS templates" support introduced in r797. (This is not an API change because domicile is not part of our documented interface.) @r5425

Patch Set 1 #

Total comments: 3

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -166 lines)			Patch
	M	src/com/google/caja/parser/quasiliteral/ReservedNames.java	View		2 chunks	+0 lines, -12 lines	0 comments	Download
	M	src/com/google/caja/plugin/domado.js	View		15 chunks	+43 lines, -154 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

felix8a

lgtm https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/domado.js#newcode633 src/com/google/caja/plugin/domado.js:633: var NO_PROPERTY = null; now that NO_PROPERTY is ...

12 years, 10 months ago (2013-05-28 20:06:02 UTC) #2

kpreid2

https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/domado.js#newcode633 src/com/google/caja/plugin/domado.js:633: var NO_PROPERTY = null; On 2013/05/28 20:06:02, felix8a wrote: ...

12 years, 10 months ago (2013-05-28 20:27:14 UTC) #3

felix8a

12 years, 10 months ago (2013-05-29 00:53:07 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/doma...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/9831044/diff/1/src/com/google/caja/plugin/doma...
src/com/google/caja/plugin/domado.js:633: var NO_PROPERTY = null;
On 2013/05/28 20:27:14, kpreid2 wrote:
> On 2013/05/28 20:06:02, felix8a wrote:
> > now that NO_PROPERTY is exposed, maybe give it a less accidental value?
> 
> I'm on the fence about whether it should even be a named value. But I think
null
> is sufficient, because null doesn't arise implicitly like undefined does.

either way is ok with me. I guess it's the on-the-fence of it that feels odd to
me, heh.

Expand All Messages | Collapse All Messages