capture useful info after browser tests

html capture is an approximation of the dom, basically .innerHTML.
I'm unsure how inaccurate it can be.

screenshot capture is pretty reliable when available.

logs capture is pretty useless right now, because webdriver doesn't
give us what we want.

[felix8a, 2013-06-12 06:46:39]

er, wait. screenshot capture fails for the scanner.

[felix8a, 2013-06-12 07:06:31]

html capture is an approximation of the dom, basically .innerHTML.
I'm unsure how inaccurate it can be.

screenshot capture is pretty reliable when available.

logs capture is pretty useless right now, because webdriver doesn't
give us what we want.

[felix8a, 2013-06-12 07:08:57]

On 2013/06/12 06:46:39, felix8a wrote:
> er, wait. screenshot capture fails for the scanner.

not sure why screenshot is failing for that test, maybe just that it's too
large?
for now, just making a best-effort screenshot grab.

[kpreid2, 2013-06-12 16:43:07]

LGTM

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/BrowserTestCase.java:120: {
I don't think the { on another line is our usual coding style, is it?

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/WebDriverHandle.java (right):

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/WebDriverHandle.java:231: // ignore
Please log this failure.

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/WebDriverHandle.java:262: private void
saveToFile(String fileName, byte[] bytes) {
I'm pretty sure we already have these somewhere in our classpath...

Yeah, try org.apache.commons.io.FileUtils; has string and array versions.

[felix8a, 2013-06-12 19:51:31]

@r5446

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/WebDriverHandle.java (right):

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/WebDriverHandle.java:231: // ignore
On 2013/06/12 16:43:07, kpreid2 wrote:
> Please log this failure.

Done.

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/WebDriverHandle.java:262: private void
saveToFile(String fileName, byte[] bytes) {
On 2013/06/12 16:43:07, kpreid2 wrote:
> I'm pretty sure we already have these somewhere in our classpath...
> 
> Yeah, try org.apache.commons.io.FileUtils; has string and array versions.

ok I just tried using FileUtils instead and it turns out not to be any simpler,
because I still need all the try/catch code. basically, it just saves 2 lines of
code. so, I'm not doing it.