Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 9827044: Added support for EXT_frag_depth (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Brandon Jones
Modified:
6 years, 2 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added support for EXT_frag_depth This change also required that support be added for associating built-in variables with an extension, similar to how functions could be associated with extensions previously. R=alokp@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=2248

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -57 lines) Patch
M include/GLSLANG/ShaderLang.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/BaseTypes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/Initialize.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/OutputGLSL.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/OutputGLSL.cpp View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/OutputHLSL.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/ParseHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/SymbolTable.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/glslang.y View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 1 17 chunks +79 lines, -42 lines 0 comments Download
M src/libGLESv2/Context.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/ProgramBinary.cpp View 2 chunks +17 lines, -5 lines 0 comments Download
M src/libGLESv2/Shader.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Brandon Jones
6 years, 2 months ago (2013-05-28 18:18:06 UTC) #1
Shannon Woods
Adding Nicolas as a reviewer.
6 years, 2 months ago (2013-05-28 18:31:08 UTC) #2
nicolas%transgaming.com
Please also note that soon things will switch over to the dx11proto branch (but using ...
6 years, 2 months ago (2013-05-28 19:16:32 UTC) #3
nicolas%transgaming.com
Meant to publish these comments at the same time... https://codereview.appspot.com/9827044/diff/1/src/compiler/Initialize.cpp File src/compiler/Initialize.cpp (right): https://codereview.appspot.com/9827044/diff/1/src/compiler/Initialize.cpp#newcode543 src/compiler/Initialize.cpp:543: ...
6 years, 2 months ago (2013-05-28 19:17:13 UTC) #4
Alok Priyadarshi
https://codereview.appspot.com/9827044/diff/1/src/compiler/OutputGLSL.cpp File src/compiler/OutputGLSL.cpp (right): https://codereview.appspot.com/9827044/diff/1/src/compiler/OutputGLSL.cpp#newcode26 src/compiler/OutputGLSL.cpp:26: TString name = node->getSymbol(); there is no need for ...
6 years, 2 months ago (2013-05-28 19:25:35 UTC) #5
Brandon Jones
I'm already working on ensuring these changes work with the dx11 branch. I assume I ...
6 years, 2 months ago (2013-05-28 19:30:41 UTC) #6
Shannon Woods
On 2013/05/28 19:25:35, Alok Priyadarshi wrote: > https://codereview.appspot.com/9827044/diff/1/src/compiler/ParseHelper.cpp#newcode934 > src/compiler/ParseHelper.cpp:934: if (symbol == 0) { ...
6 years, 2 months ago (2013-05-28 19:50:37 UTC) #7
nicolas%transgaming.com
On 2013/05/28 19:30:41, Brandon Jones wrote: > On 2013/05/28 19:17:14, http://nicolas%25transgaming.com wrote: > > This ...
6 years, 2 months ago (2013-05-28 20:50:38 UTC) #8
Brandon Jones
Regenerated glslang_tab.cpp with Bison 2.7. I think I'll leave the braces on the if statement ...
6 years, 2 months ago (2013-05-28 20:54:34 UTC) #9
Brandon Jones
And I've now addressed the Medium/High precision issue as well
6 years, 2 months ago (2013-05-28 21:01:57 UTC) #10
Alok Priyadarshi
https://codereview.appspot.com/9827044/diff/12001/src/compiler/OutputGLSL.cpp File src/compiler/OutputGLSL.cpp (right): https://codereview.appspot.com/9827044/diff/12001/src/compiler/OutputGLSL.cpp#newcode26 src/compiler/OutputGLSL.cpp:26: TString name = node->getSymbol(); Please delete this local variable ...
6 years, 2 months ago (2013-05-28 21:05:36 UTC) #11
Brandon Jones
On 2013/05/28 21:05:36, Alok Priyadarshi wrote: > https://codereview.appspot.com/9827044/diff/12001/src/compiler/OutputGLSL.cpp > File src/compiler/OutputGLSL.cpp (right): > > https://codereview.appspot.com/9827044/diff/12001/src/compiler/OutputGLSL.cpp#newcode26 ...
6 years, 2 months ago (2013-05-28 21:38:21 UTC) #12
Alok Priyadarshi
lgtm Is there a WebGL conformance test for this?
6 years, 2 months ago (2013-05-28 21:43:37 UTC) #13
Brandon Jones
On 2013/05/28 21:43:37, Alok Priyadarshi wrote: > lgtm > > Is there a WebGL conformance ...
6 years, 2 months ago (2013-05-28 21:53:11 UTC) #14
Brandon Jones
6 years, 2 months ago (2013-05-28 22:16:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 manually as r2248 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b