Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(116)

Issue 98100043: RFC6962-bis issue #2: log submitters should verify SCTs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by Eran
Modified:
8 years ago
CC:
ctlog-opensource-review_google.com
Visibility:
Public.

Description

RFC6962-bis issue #2: log submitters should verify SCTs

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing review comments #

Total comments: 1

Patch Set 3 : Indicating submitters do not have to verify SCT with an unknown format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M doc/rfc6962-bis.xml View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13
Rob Stradling
https://codereview.appspot.com/98100043/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/98100043/diff/1/doc/rfc6962-bis.xml#newcode836 doc/rfc6962-bis.xml:836: If the <spanx style="verb">sct_version</spanx> is not v1, then a ...
8 years ago (2014-05-09 10:11:47 UTC) #1
Eran
PTAL. https://codereview.appspot.com/98100043/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/98100043/diff/1/doc/rfc6962-bis.xml#newcode836 doc/rfc6962-bis.xml:836: If the <spanx style="verb">sct_version</spanx> is not v1, then ...
8 years ago (2014-05-09 11:59:50 UTC) #2
Rob Stradling
On 2014/05/09 11:59:50, Eran wrote: > PTAL. <snip> LGTM
8 years ago (2014-05-12 12:47:59 UTC) #3
Rob Stradling
8 years ago (2014-05-12 12:48:47 UTC) #4
Ben Laurie (Google)
https://codereview.appspot.com/98100043/diff/20001/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/98100043/diff/20001/doc/rfc6962-bis.xml#newcode1102 doc/rfc6962-bis.xml:1102: Submitters submit certificates or Precertificates to the log as ...
8 years ago (2014-05-14 13:17:09 UTC) #5
Rob Stradling
On 2014/05/14 13:17:09, Ben Laurie (Google) wrote: > https://codereview.appspot.com/98100043/diff/20001/doc/rfc6962-bis.xml > File doc/rfc6962-bis.xml (right): > > ...
8 years ago (2014-05-14 14:34:28 UTC) #6
Ben Laurie (Google)
On 14 May 2014 15:34, <robstrad@gmail.com> wrote: > On 2014/05/14 13:17:09, Ben Laurie (Google) wrote: ...
8 years ago (2014-05-15 10:55:28 UTC) #7
Rob Stradling
On 2014/05/15 10:55:28, Ben Laurie (Google) wrote: > On 14 May 2014 15:34, <mailto:robstrad@gmail.com> wrote: ...
8 years ago (2014-05-15 11:17:51 UTC) #8
Ben Laurie (Google)
On 15 May 2014 12:17, <robstrad@gmail.com> wrote: > On 2014/05/15 10:55:28, Ben Laurie (Google) wrote: ...
8 years ago (2014-05-15 11:36:15 UTC) #9
Rob Stradling
OK. So can we tweak the proposed text to something like... "...they SHOULD validate the ...
8 years ago (2014-05-15 11:51:15 UTC) #10
Ben Laurie (Google)
On 15 May 2014 12:51, <robstrad@gmail.com> wrote: > OK. So can we tweak the proposed ...
8 years ago (2014-05-15 15:56:36 UTC) #11
Eran
On 2014/05/15 15:56:36, Ben Laurie (Google) wrote: > On 15 May 2014 12:51, <mailto:robstrad@gmail.com> wrote: ...
8 years ago (2014-05-21 15:34:39 UTC) #12
Eran
8 years ago (2014-05-21 15:53:45 UTC) #13
On 2014/05/21 15:34:39, Eran wrote:
> On 2014/05/15 15:56:36, Ben Laurie (Google) wrote:
> > On 15 May 2014 12:51,  <mailto:robstrad@gmail.com> wrote:
> > > OK.  So can we tweak the proposed text to something like...
> > >
> > > "...they SHOULD validate the SCT as described in <xref
> > > target="tls_clients"/> if they understand its format."
> > >
> > > ...and then close this issue?
> > 
> > Sounds OK to me.
> Done.
> > 
> > >
> > > https://codereview.appspot.com/98100043/
> > 
> > 
> > 
> > -- 
> > Certificate Transparency is hiring! Let me know if you're interested.

Pushed as
https://github.com/google/certificate-transparency/commit/d215e581ff59f51d132...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b