Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 98080: Exposes an entry point to cajole gadgets which have already been parsed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by Jasvir
Modified:
16 years, 8 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added an entry point to DefaultGadgetRewriter (used by Shindig) which accepts a parsed node. @3617

Patch Set 1 #

Total comments: 2

Patch Set 2 : Exposes an entry point to cajole gadgets which have already been parsed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M src/com/google/caja/opensocial/DefaultGadgetRewriter.java View 1 4 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 4
Jasvir
16 years, 10 months ago (2009-07-30 23:57:19 UTC) #1
MikeSamuel
http://codereview.appspot.com/98080/diff/1/2 File src/com/google/caja/opensocial/DefaultGadgetRewriter.java (right): http://codereview.appspot.com/98080/diff/1/2#newcode184 Line 184: scriptElement.appendChild(doc.createTextNode(script.toString())); This doesn't look right. It looks like ...
16 years, 10 months ago (2009-07-31 00:54:51 UTC) #2
Jasvir
http://codereview.appspot.com/98080/diff/1/2 File src/com/google/caja/opensocial/DefaultGadgetRewriter.java (right): http://codereview.appspot.com/98080/diff/1/2#newcode184 Line 184: scriptElement.appendChild(doc.createTextNode(script.toString())); On 2009/07/31 00:54:52, MikeSamuel wrote: > This ...
16 years, 10 months ago (2009-07-31 02:33:24 UTC) #3
MikeSamuel
16 years, 10 months ago (2009-07-31 02:58:36 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b