Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 9798051: fix test-domado-events flakiness (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by felix8a
Modified:
12 years, 9 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

test-domado-events in any flavor occasionally has 2 failures because of a timing issue. The test driver gets a list of all clickable elements, clicks on each one, then repeats that process. testHandlerAttributeArguments as written requires two different click handlers to fire before it passes. How it fails: - driver gets list of elements, including elem1 and elem2 - driver clicks elem1, which doesn't have a click handler installed yet - jsunit runs testHandlerAttributeArguments, which installs the handlers - driver clicks elem2, triggering half of the pass condition - driver rescans for elements to click, including elem1 and elem2 - driver clicks elem1, triggering the other half of the pass condition - driver clicks elem2, triggering pass a second time, which is an error the fix is to split the test into two separate tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M tests/com/google/caja/plugin/es53-test-domado-events-guest.html View 2 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 9 months ago (2013-06-04 00:28:20 UTC) #1
kpreid2
LGTM
12 years, 9 months ago (2013-06-04 17:00:47 UTC) #2
felix8a
12 years, 9 months ago (2013-06-04 19:21:39 UTC) #3
@r5437
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b