Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 979047: c-api/arg.rst doc fixes

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Antoine Pitrou
Modified:
11 years, 7 months ago
Reviewers:
brian.curtin, merwok
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -95 lines) Patch
M Doc/c-api/arg.rst View 9 chunks +140 lines, -95 lines 10 comments Download

Messages

Total messages: 3
merwok
Some minor comments. The rest seems good to me, although I don’t know C. http://codereview.appspot.com/979047/diff/1/2 ...
11 years, 7 months ago (2010-05-01 21:31:50 UTC) #1
Antoine Pitrou
http://codereview.appspot.com/979047/diff/1/2 File Doc/c-api/arg.rst (right): http://codereview.appspot.com/979047/diff/1/2#newcode34 Doc/c-api/arg.rst:34: or bytes. Also, you won't have to release any ...
11 years, 7 months ago (2010-05-01 21:39:14 UTC) #2
brian.curtin
11 years, 7 months ago (2010-05-02 00:06:57 UTC) #3
http://codereview.appspot.com/979047/diff/1/2
File Doc/c-api/arg.rst (right):

http://codereview.appspot.com/979047/diff/1/2#newcode34
Doc/c-api/arg.rst:34: or bytes.  Also, you won't have to release any memory
yourself, except with
On 2010/05/01 21:31:50, merwok wrote:
> “or bytes object” seems less awkward to me
> “except for” (gut feeling)

I think "except with" is correct if "formats" is put at the end of the list of
formats. I'm not a fan of "except for".

http://codereview.appspot.com/979047/diff/1/2#newcode57
Doc/c-api/arg.rst:57: Convert an Unicode object to a C pointer to a character
string.
an Unicode -> a Unicode

http://codereview.appspot.com/979047/diff/1/2#newcode58
Doc/c-api/arg.rst:58: A pointer to an existing string is stored into the
character pointer
stored into -> stored in

http://codereview.appspot.com/979047/diff/1/2#newcode79
Doc/c-api/arg.rst:79: As ``s*``, except that it doesn't accept mutable
buffer-like objects
The beginning reads kind of weird. Maybe "Like ``s*``"?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b