Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 977046: Explicitly use UTF-8 when turning strings to byte arrays

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by jtarrio
Modified:
15 years, 8 months ago
Reviewers:
johnfargo, zhoresh, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

For peace of mind, I'd like to specify that the UTF-8 encoding is used every time a string is turned into a byte array. I only left the original getBytes() calls in some unit tests where UTF-8 conversions were unnecessary, as when dealing with Base32 or Base64 data, or when using it to generate a crypto key for testing purposes with a fixed string.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -68 lines) Patch
java/common/src/main/java/org/apache/shindig/common/util/Base32.java View 2 chunks +7 lines, -1 line 1 comment Download
java/common/src/test/java/org/apache/shindig/protocol/JsonRpcServletTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/protocol/multipart/DefaultMultipartFormParserTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultUrlGenerator.java View 2 chunks +6 lines, -1 line 1 comment Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthCommandLine.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java View 2 chunks +6 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java View 3 chunks +11 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssLexerParser.java View 2 chunks +6 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java View 2 chunks +6 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 2 chunks +7 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java View 2 chunks +6 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java View 2 chunks +6 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AllJsIframeVersioner.java View 2 chunks +7 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsVersioner.java View 2 chunks +8 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpRequestTest.java View 4 chunks +6 lines, -5 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseBuilderTest.java View 3 chunks +5 lines, -4 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java View 6 chunks +12 lines, -13 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HttpRequestHandlerTest.java View 9 chunks +12 lines, -12 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/AllJsIframeVersionerTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/core/oauth/FakeOAuthRequest.java View 1 chunk +2 lines, -1 line 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2
jtarrio
15 years, 8 months ago (2010-04-30 21:25:06 UTC) #1
zhoresh
15 years, 8 months ago (2010-05-04 08:45:43 UTC) #2
http://codereview.appspot.com/977046/diff/1/6
File java/common/src/main/java/org/apache/shindig/common/util/Base32.java
(right):

http://codereview.appspot.com/977046/diff/1/6#newcode40
java/common/src/main/java/org/apache/shindig/common/util/Base32.java:40: return
ENCODER.encode(arg0).getBytes("US-ASCII");
You can use StringUtils.getBytesUsAscii which already convert the exception to
runtime exception.

http://codereview.appspot.com/977046/diff/1/23
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultUrlGenerator.java
(right):

http://codereview.appspot.com/977046/diff/1/23#newcode85
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultUrlGenerator.java:85:
jsChecksum = HashUtil.checksum(jsBuf.toString().getBytes("UTF-8"));
Maybe use StringUtils.getBytesUtf8 instead which already convert the exception
for you (an probably in many other places)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b