Scroll message reply into view on main issue page.

Scroll message reply into view on main issue page.

This also scrolls the textarea to the bottom, so that the user can start to write the reply below the original post without adjusting the view first.

I've just applied jparent1's patch that makes the textarea bigger (https://codereview.appspot.com/9762044/). This reminded me of this feature I always wanted to add. But now with a bigger textarea it makes even more sense IMO :)

This is live at https://rvtests.appspot.com

[M-A, 2013-05-25 12:57:53]

lgtm
Le 25 mai 2013 01:04, <albrecht.andi@gmail.com> a écrit :

> Reviewers: M-A, jparent1,
>
> Description:
> Scroll message reply into view on main issue page.
>
> This also scrolls the textarea to the bottom, so that the user can start
> to write the reply below the original post without adjusting the view
> first.
>
> I've just applied jparent1's patch that makes the textarea bigger
>
(https://codereview.appspot.**com/9762044/<https://codereview.appspot.com/9762...).
> This reminded me of this
> feature I always wanted to add. But now with a bigger textarea it makes
> even more sense IMO :)
>
> Please review this at
http://codereview.appspot.com/**9766043/<http://codereview.appspot.com/9766043/>
>
> Affected files:
>   M static/script.js
>
>
> Index: static/script.js
> ==============================**==============================**=======
> --- a/static/script.js
> +++ b/static/script.js
> @@ -677,6 +677,10 @@
>      M_setValueFromDivs(divs, form.message);
>      form.message.value += "\n";
>    }
> +  // Scroll view to bottom of message textarea and scroll textarea to
> bottom
> +  // too, so that the user can write w/o adjusting the views first.
> +  M_scrollIntoView(window, form.send_mail, 1);
> +  form.message.scrollTop = form.message.scrollHeight;
>    M_addTextResizer_(form);
>    M_hideElement(replyLink);
>  }
>
>
>

[Andi, 2013-05-25 20:04:04]

On 2013/05/25 12:57:53, M-A wrote:
> lgtm
> Le 25 mai 2013 01:04, <mailto:albrecht.andi@gmail.com> a écrit :
> 
> > Reviewers: M-A, jparent1,
> >
> > Description:
> > Scroll message reply into view on main issue page.
> >
> > This also scrolls the textarea to the bottom, so that the user can start
> > to write the reply below the original post without adjusting the view
> > first.
> >
> > I've just applied jparent1's patch that makes the textarea bigger
> >
>
(https://codereview.appspot.**com/9762044/%3Chttps://codereview.appspot.com/97...>).
> > This reminded me of this
> > feature I always wanted to add. But now with a bigger textarea it makes
> > even more sense IMO :)
> >
> > Please review this at
>
http://codereview.appspot.com/**9766043/%3Chttp://codereview.appspot.com/9766...>
> >
> > Affected files:
> >   M static/script.js
> >
> >
> > Index: static/script.js
> > ==============================**==============================**=======
> > --- a/static/script.js
> > +++ b/static/script.js
> > @@ -677,6 +677,10 @@
> >      M_setValueFromDivs(divs, form.message);
> >      form.message.value += "\n";
> >    }
> > +  // Scroll view to bottom of message textarea and scroll textarea to
> > bottom
> > +  // too, so that the user can write w/o adjusting the views first.
> > +  M_scrollIntoView(window, form.send_mail, 1);
> > +  form.message.scrollTop = form.message.scrollHeight;
> >    M_addTextResizer_(form);
> >    M_hideElement(replyLink);
> >  }
> >
> >
> >

committed and live. Thanks!