Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(528)

Issue 9762044: Make the comment text area on the main issue page larger too.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by jparent1
Modified:
12 years, 6 months ago
Reviewers:
whesse, Andi, iannucci
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Make the comment text area on the main issue page larger too.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M templates/issue.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
jparent1
12 years, 7 months ago (2013-05-25 00:56:34 UTC) #1
jparent1
On 2013/05/25 00:56:34, jparent1 wrote: Just like on diff page (https://codereview.appspot.com/9598048/), make the comment textarea ...
12 years, 7 months ago (2013-05-25 00:59:34 UTC) #2
Andi
On 2013/05/25 00:59:34, jparent1 wrote: > On 2013/05/25 00:56:34, jparent1 wrote: > > Just like ...
12 years, 7 months ago (2013-05-25 05:06:18 UTC) #3
Andi
On 2013/05/25 05:06:18, Andi wrote: > On 2013/05/25 00:59:34, jparent1 wrote: > > On 2013/05/25 ...
12 years, 7 months ago (2013-05-25 20:04:16 UTC) #4
whesse
On 2013/05/25 20:04:16, Andi wrote: > On 2013/05/25 05:06:18, Andi wrote: > > On 2013/05/25 ...
12 years, 7 months ago (2013-05-28 11:27:56 UTC) #5
jparent1
@whesse - Can you explain more? I am not seeing that problem, but also, I'm ...
12 years, 7 months ago (2013-05-28 16:35:45 UTC) #6
whesse
12 years, 7 months ago (2013-05-28 16:39:07 UTC) #7
Ok, I'll try and make sure it's not just me.  I just switched window
managers, and am on Chrome on 24" profile monitors.  So I'll look into
it more, and try and find out what change caused it.

On Tue, May 28, 2013 at 6:35 PM, Julie Parent <jparent@chromium.org> wrote:
> @whesse - Can you explain more?  I am not seeing that problem, but also, I'm
> pretty sure this change hasn't be integrated into chromium's rietveld yet
> ...
>
>
> On Tue, May 28, 2013 at 4:27 AM, <whesse@google.com> wrote:
>>
>> On 2013/05/25 20:04:16, Andi wrote:
>>>
>>> On 2013/05/25 05:06:18, Andi wrote:
>>> > On 2013/05/25 00:59:34, jparent1 wrote:
>>> > > On 2013/05/25 00:56:34, jparent1 wrote:
>>> > >
>>> > > Just like on diff page (https://codereview.appspot.com/9598048/),
>>
>> make the
>>>
>>> > > comment textarea on the main issue page larger.
>>> > >
>>> > > Demo at: https://codereview-julie-test.appspot.com
>>> >
>>> > LGTM, Thanks! I've already it in my local repo but I'd like to wait
>>
>> for
>>>
>>> comments
>>> > on my follow-up review (https://codereview.appspot.com/9766043/)
>>
>> before
>>>
>>> > publishing it.
>>
>>
>>> committed and live. Thanks!
>>
>>
>> The main issue page at https://codereview.chromium.org/ now overflows
>> horizontally, and the last modified time is no longer visible without
>> scrolling.  This makes it hard to see which reviews are new.  This
>> happens whether you are signed in or not.  It also overflows the
>> borders.
>>
>>
>> https://codereview.appspot.com/9762044/
>
>



-- 
William Hesse
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b