On 2013/05/25 05:06:18, Andi wrote: > On 2013/05/25 00:59:34, jparent1 wrote: > > On 2013/05/25 ...
12 years, 7 months ago
(2013-05-25 20:04:16 UTC)
#4
On 2013/05/25 05:06:18, Andi wrote:
> On 2013/05/25 00:59:34, jparent1 wrote:
> > On 2013/05/25 00:56:34, jparent1 wrote:
> >
> > Just like on diff page (https://codereview.appspot.com/9598048/), make the
> > comment textarea on the main issue page larger.
> >
> > Demo at: https://codereview-julie-test.appspot.com
>
> LGTM, Thanks! I've already it in my local repo but I'd like to wait for
comments
> on my follow-up review (https://codereview.appspot.com/9766043/) before
> publishing it.
committed and live. Thanks!
On 2013/05/25 20:04:16, Andi wrote: > On 2013/05/25 05:06:18, Andi wrote: > > On 2013/05/25 ...
12 years, 7 months ago
(2013-05-28 11:27:56 UTC)
#5
On 2013/05/25 20:04:16, Andi wrote:
> On 2013/05/25 05:06:18, Andi wrote:
> > On 2013/05/25 00:59:34, jparent1 wrote:
> > > On 2013/05/25 00:56:34, jparent1 wrote:
> > >
> > > Just like on diff page (https://codereview.appspot.com/9598048/), make the
> > > comment textarea on the main issue page larger.
> > >
> > > Demo at: https://codereview-julie-test.appspot.com
> >
> > LGTM, Thanks! I've already it in my local repo but I'd like to wait for
> comments
> > on my follow-up review (https://codereview.appspot.com/9766043/) before
> > publishing it.
>
> committed and live. Thanks!
The main issue page at https://codereview.chromium.org/ now overflows
horizontally, and the last modified time is no longer visible without scrolling.
This makes it hard to see which reviews are new. This happens whether you are
signed in or not. It also overflows the borders.
Ok, I'll try and make sure it's not just me. I just switched window managers, ...
12 years, 7 months ago
(2013-05-28 16:39:07 UTC)
#7
Ok, I'll try and make sure it's not just me. I just switched window
managers, and am on Chrome on 24" profile monitors. So I'll look into
it more, and try and find out what change caused it.
On Tue, May 28, 2013 at 6:35 PM, Julie Parent <jparent@chromium.org> wrote:
> @whesse - Can you explain more? I am not seeing that problem, but also, I'm
> pretty sure this change hasn't be integrated into chromium's rietveld yet
> ...
>
>
> On Tue, May 28, 2013 at 4:27 AM, <whesse@google.com> wrote:
>>
>> On 2013/05/25 20:04:16, Andi wrote:
>>>
>>> On 2013/05/25 05:06:18, Andi wrote:
>>> > On 2013/05/25 00:59:34, jparent1 wrote:
>>> > > On 2013/05/25 00:56:34, jparent1 wrote:
>>> > >
>>> > > Just like on diff page (https://codereview.appspot.com/9598048/),
>>
>> make the
>>>
>>> > > comment textarea on the main issue page larger.
>>> > >
>>> > > Demo at: https://codereview-julie-test.appspot.com
>>> >
>>> > LGTM, Thanks! I've already it in my local repo but I'd like to wait
>>
>> for
>>>
>>> comments
>>> > on my follow-up review (https://codereview.appspot.com/9766043/)
>>
>> before
>>>
>>> > publishing it.
>>
>>
>>> committed and live. Thanks!
>>
>>
>> The main issue page at https://codereview.chromium.org/ now overflows
>> horizontally, and the last modified time is no longer visible without
>> scrolling. This makes it hard to see which reviews are new. This
>> happens whether you are signed in or not. It also overflows the
>> borders.
>>
>>
>> https://codereview.appspot.com/9762044/
>
>
--
William Hesse
Issue 9762044: Make the comment text area on the main issue page larger too.
Created 12 years, 7 months ago by jparent1
Modified 12 years, 6 months ago
Reviewers: iannucci, whesse
Base URL:
Comments: 0