Shindig SecurityTokenDecoder -> SecurityTokenCodec - part 1

[Paul Lindner, 2010-04-23 22:01:16]

Hi,

here's a patch that adds a new method to the securitytokendecoder interface. 
Once this is place we can rename these classes to xxxxCodec instead of
xxxxDecoder. 

The rationale here is to allow for a simple way for shindig to generate the
security tokens on a metadata call for a given HttpServletRequest (more on that
in a later patch..)

[zhoresh, 2010-04-23 22:34:39]

I like the idea of having one service to decode (createToken) and encode the
tokens.

http://codereview.appspot.com/975043/diff/1/2
File
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoder.java
(right):

http://codereview.appspot.com/975043/diff/1/2#newcode122
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoder.java:122:
BlobCrypterSecurityToken t = (BlobCrypterSecurityToken)token;
Since it is public function, I think it would be best to do safe casting here.

[Paul Lindner, 2010-04-23 22:51:47]

On 2010/04/23 22:34:39, zhoresh wrote:
> I like the idea of having one service to decode (createToken) and encode the
> tokens.
> 
> http://codereview.appspot.com/975043/diff/1/2
> File
>
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoder.java
> (right):
> 
> http://codereview.appspot.com/975043/diff/1/2#newcode122
>
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoder.java:122:
> BlobCrypterSecurityToken t = (BlobCrypterSecurityToken)token;
> Since it is public function, I think it would be best to do safe casting here.

done.

[chirag, 2010-04-23 22:55:53]

lgtm

[zhoresh, 2010-04-23 23:01:36]

lgtm

[Paul Lindner, 2010-04-24 00:56:43]

in it goes :)

more patches to come..

On Fri, Apr 23, 2010 at 4:01 PM, <zhoresh@gmail.com> wrote:

> lgtm
>
> http://codereview.appspot.com/975043/show
>