Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1287)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Delta Between Two Patch Sets: test/fixedbugs/issue7995b.dir/x2.go
Issue
97500044
:
code review 97500044: cmd/gc: correct handling of globals, func args, results (Closed)
Left Patch Set: diff -r 712f6b41d382 https://code.google.com/p/go/
Created 10 years, 10 months ago
Right Patch Set: diff -r f099be9eddaa https://code.google.com/p/go/
Created 10 years, 10 months ago
Left:
Base
Patch Set 1: None
Patch Set 2: diff -r 712f6b41d382 https://code.google.com/p/go/
Patch Set 3: diff -r b10044024a6d https://code.google.com/p/go/
Patch Set 4: diff -r f099be9eddaa https://code.google.com/p/go/
Right:
Patch Set 1: None
Patch Set 2: diff -r 712f6b41d382 https://code.google.com/p/go/
Patch Set 3: diff -r b10044024a6d https://code.google.com/p/go/
Patch Set 4: diff -r f099be9eddaa https://code.google.com/p/go/
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
src/cmd/5g/reg.c
src/cmd/6g/reg.c
src/cmd/8g/reg.c
test/fixedbugs/issue1304.go
test/fixedbugs/issue7995.go
test/fixedbugs/issue7995b.go
test/fixedbugs/issue7995b.dir/x1.go
test/fixedbugs/issue7995b.dir/x2.go
test/nilptr3.go
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« test/fixedbugs/issue7995b.dir/x1.go
('k') |
test/nilptr3.go »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
package main
2
3
import "./x1"
4
5
func main() {
6
s := x1.F(&x1.P)
7
if s != "100 100\n" {
8
println("BUG:", s)
9
}
10
}
LEFT
RIGHT
« test/fixedbugs/issue7995b.dir/x1.go
('k') |
test/nilptr3.go »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Issue 97500044: code review 97500044: cmd/gc: correct handling of globals, func args, results (Closed)
Created 10 years, 10 months ago by rsc
Modified 10 years, 10 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
