https://codereview.appspot.com/9739043/diff/1/hg_import.py File hg_import.py (right): https://codereview.appspot.com/9739043/diff/1/hg_import.py#newcode47 hg_import.py:47: subprocess.check_call([hg_cmd, 'import'] + force + ['--no-commit', url]) what happen if force = [] - is it valid? Did you test it with both -f and without?
https://codereview.appspot.com/9739043/diff/1/hg_import.py File hg_import.py (right): https://codereview.appspot.com/9739043/diff/1/hg_import.py#newcode47 hg_import.py:47: subprocess.check_call([hg_cmd, 'import'] + force + ['--no-commit', url]) On 2013/05/30 13:29:07, peleyal wrote: > what happen if force = [] - is it valid? Yes. > Did you test it with both -f and without? Yes. Also: python -c "print ['a'] + [] + ['b']" ['a', 'b']
LGTM