Issue 9735045: cmd/jujud: connect to API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9735045: cmd/jujud: connect to API

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rog

Modified:
10 years, 11 months ago

Reviewers:
mp+165746, fwereade

Visibility:
Public.

Description

cmd/jujud: connect to API We refactor the agents to use worker.Runner, which leads to some simplification. https://code.launchpad.net/~rogpeppe/juju-core/305-jujud-use-tasks-package/+merge/165746 Requires: https://code.launchpad.net/~rogpeppe/juju-core/315-api-dialopts/+merge/165744 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+302 lines, -412 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View	5 chunks	+102 lines, -96 lines	0 comments	Download
M	cmd/jujud/agent_test.go	View	3 chunks	+2 lines, -144 lines	0 comments	Download
M	cmd/jujud/machine.go	View	4 chunks	+108 lines, -115 lines	1 comment	Download
M	cmd/jujud/machine_test.go	View	7 chunks	+24 lines, -12 lines	0 comments	Download
M	cmd/jujud/unit.go	View	3 chunks	+33 lines, -27 lines	0 comments	Download
M	cmd/jujud/upgrade.go	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	environs/agent/agent.go	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	state/api/params/params.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/apiserver/apiserver.go	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	state/life.go	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	state/state_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/runner.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

fwereade

10 years, 11 months ago (2013-06-05 12:47:33 UTC) #1

This is lovely. Can't wait to see it finished and proposed.

https://codereview.appspot.com/9735045/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/9735045/diff/1/cmd/jujud/machine.go#newcode79
cmd/jujud/machine.go:79: if a.MachineId == "0" {
Please use the constant in state, not "0" :).

Expand All Messages | Collapse All Messages