Remove g_type_init() calls.

Remove g_type_init() calls.

https://git.gnome.org/browse/glib/commit/?id=1dc774a653e992e1153fbed16f90097fa8db467f
https://git.gnome.org/browse/vala/commit/?id=f1fbafdfdc91fadaa57d2e073fc29cc6804d6ae3

[Peng, 2013-06-03 14:58:42]

On 2013/05/31 17:57:03, fujiwara wrote:

lgtm

[Daiki Ueno, 2013-06-10 06:04:12]

https://codereview.appspot.com/9727047/diff/3001/configure.ac
File configure.ac (right):

https://codereview.appspot.com/9727047/diff/3001/configure.ac#newcode156
configure.ac:156: GLIB_VERSION=`$PKG_CONFIG --modversion glib-2.0`
See my next comment.

https://codereview.appspot.com/9727047/diff/3001/ui/gtk3/Makefile.am
File ui/gtk3/Makefile.am (right):

https://codereview.appspot.com/9727047/diff/3001/ui/gtk3/Makefile.am#newcode84
ui/gtk3/Makefile.am:84: --target-glib="$(GLIB_VERSION)" \
Well, notice that tarball includes *.c files generated from *.vala.

If you do "make dist" with glib 2.36, generated *.c code won't have
g_type_init() call and thus cause unexpected error when compiled with earlier
glib versions (when no valac installed).  As $glib_required_version is still
2.32.0, it is not intended I guess.

If you simply want to silence the warning while developing, you could supply
GLIB_VERSION through a configure option (e.g. --with-glib) and add
--with-glib=2.32 to DISTCHECK_CONFIGURE_FLAGS, though it might be too much.  If
I were you, I would simply ignore the warning for the Vala code, until 2.36 gets
widely used.

[fujiwara, 2013-06-10 07:10:11]

On 2013/06/10 06:04:12, Daiki Ueno wrote:
> https://codereview.appspot.com/9727047/diff/3001/configure.ac
> File configure.ac (right):
> 
> https://codereview.appspot.com/9727047/diff/3001/configure.ac#newcode156
> configure.ac:156: GLIB_VERSION=`$PKG_CONFIG --modversion glib-2.0`
> See my next comment.
> 
> https://codereview.appspot.com/9727047/diff/3001/ui/gtk3/Makefile.am
> File ui/gtk3/Makefile.am (right):
> 
> https://codereview.appspot.com/9727047/diff/3001/ui/gtk3/Makefile.am#newcode84
> ui/gtk3/Makefile.am:84: --target-glib="$(GLIB_VERSION)" \
> Well, notice that tarball includes *.c files generated from *.vala.
> 
> If you do "make dist" with glib 2.36, generated *.c code won't have
> g_type_init() call and thus cause unexpected error when compiled with earlier
> glib versions (when no valac installed).  As $glib_required_version is still
> 2.32.0, it is not intended I guess.
> 
> If you simply want to silence the warning while developing, you could supply
> GLIB_VERSION through a configure option (e.g. --with-glib) and add
> --with-glib=2.32 to DISTCHECK_CONFIGURE_FLAGS, though it might be too much. 
If
> I were you, I would simply ignore the warning for the Vala code, until 2.36
gets
> widely used.

OK, probably ignoring the warning for vala is good at present while I fixed an
error with CFLAGS='-Werror' in this patch.
Asking vala upstream to have #ifdef also might be too costs.