Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(145)

Issue 97120: Add dump_stats() to _llvm

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 5 months ago by Collin Winter
Modified:
16 years, 5 months ago
Reviewers:
Jeffrey Yasskin
CC:
unladen-swallow_googlegroups.com
Visibility:
Public.

Description

This produces reports like this: >>> import _llvm >>> _llvm.dump_stats() LLVM functions: 1833 LLVM basic blocks: 229867 LLVM instructions: 1321540 >>>

Patch Set 1 #

Patch Set 2 : Fix 80 col violation #

Patch Set 3 : Fix indentation #

Total comments: 4

Patch Set 4 : Respond to comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M Modules/_llvm.cc View 1 2 3 3 chunks +54 lines, -1 line 1 comment Download
M setup.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
Collin Winter
PTAL
16 years, 5 months ago (2009-07-24 22:40:20 UTC) #1
Jeffrey Yasskin
http://codereview.appspot.com/97120/diff/1002/8 File Modules/_llvm.cc (right): http://codereview.appspot.com/97120/diff/1002/8#newcode56 Line 56: void WalkModule(llvm::Module *mod) { I would do this ...
16 years, 5 months ago (2009-07-25 03:55:13 UTC) #2
Collin Winter
I've dropped adding the bytes together; I'm wary of treating whatever number I come up ...
16 years, 5 months ago (2009-08-04 00:10:38 UTC) #3
Jeffrey Yasskin
16 years, 5 months ago (2009-08-04 22:59:12 UTC) #4
Otherwise, lgtm

http://codereview.appspot.com/97120/diff/1005/2001
File Modules/_llvm.cc (right):

http://codereview.appspot.com/97120/diff/1005/2001#newcode85
Line 85: fprintf(stderr, "LLVM functions: %ld\n", aggregator.FuncCount());
I think James was right that this should return a string or dict rather than
printing to stderr directly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b