Issue 971041: code review 971041: xml: new "innerxml" tag to collect inner XML

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 971041: code review 971041: xml: new "innerxml" tag to collect inner XML (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

xml: new "innerxml" tag to collect inner XML

Patch Set 2 : code review 971041: xml: new "innerxml" tag to collect inner XML #

Total comments: 1

Patch Set 3 : code review 971041: xml: new "innerxml" tag to collect inner XML #

Patch Set 4 : code review 971041: xml: new "innerxml" tag to collect inner XML #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -13 lines)			Patch
M	src/pkg/xml/read.go	View	1	6 chunks	+41 lines, -6 lines	0 comments	Download
M	src/pkg/xml/read_test.go	View	1	5 chunks	+11 lines, -7 lines	0 comments	Download
M	src/pkg/xml/xml.go	View	1 2	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-21 22:59:26 UTC) #1

http://codereview.appspot.com/971041/diff/2001/3003 File src/pkg/xml/xml.go (right): http://codereview.appspot.com/971041/diff/2001/3003#newcode712 src/pkg/xml/xml.go:712: // Return saver offset. s/saver/saved/?

14 years, 11 months ago (2010-04-21 23:07:44 UTC) #2

rsc

14 years, 11 months ago (2010-04-21 23:27:33 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=27e4933bab35 ***

xml: new "innerxml" tag to collect inner XML

R=r
CC=golang-dev
http://codereview.appspot.com/971041

Expand All Messages | Collapse All Messages