Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 97073: Make all test methods final so they can not be unintentionally overridden. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Submitted @3604

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+801 lines, -792 lines) Patch
M tests/com/google/caja/CajitaTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/config/ConfigUtilTest.java View 11 chunks +13 lines, -12 lines 0 comments Download
M tests/com/google/caja/demos/applet/CajaAppletTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/demos/applet/ExpressionLanguageStageTest.java View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/demos/applet/TestBedTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/demos/calendar/EventStoreTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/demos/calendar/HcalTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/demos/calendar/LayoutTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/demos/calendar/RRuleTest.java View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 6 chunks +12 lines, -12 lines 0 comments Download
M tests/com/google/caja/lang/css/CssSchemaTest.java View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/lang/html/HtmlSchemaTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/com/google/caja/lexer/CharProducerTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M tests/com/google/caja/lexer/CssLexerTest.java View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/lexer/DecodingCharProducerTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/lexer/FilePositionTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/lexer/HtmlLexerTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/lexer/JsLexerTest.java View 16 chunks +21 lines, -21 lines 0 comments Download
M tests/com/google/caja/lexer/PunctuationTrieTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/lexer/SourceBreaksTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/lexer/escaping/EscapingTest.java View 13 chunks +13 lines, -13 lines 0 comments Download
M tests/com/google/caja/lexer/escaping/UriUtilTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/com/google/caja/opensocial/GadgetParserTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/ParseTreeNodeTest.java View 23 chunks +38 lines, -38 lines 0 comments Download
M tests/com/google/caja/parser/ParserBaseTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/css/CssParserTest.java View 4 chunks +11 lines, -11 lines 0 comments Download
M tests/com/google/caja/parser/css/CssPropertySignatureTest.java View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/com/google/caja/parser/css/CssTreeTest.java View 6 chunks +13 lines, -13 lines 0 comments Download
M tests/com/google/caja/parser/html/DomParserTest.java View 63 chunks +66 lines, -65 lines 0 comments Download
M tests/com/google/caja/parser/html/NodesTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/js/NumberLiteralTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/js/ParserTest.java View 11 chunks +29 lines, -29 lines 0 comments Download
M tests/com/google/caja/parser/js/StringLiteralTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/CajitaRewriterTest.java View 84 chunks +117 lines, -117 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java View 17 chunks +23 lines, -19 lines 1 comment Download
M tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java View 20 chunks +33 lines, -33 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/IllegalReferenceCheckRewriterTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/InnocentCodeRewriterTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/MatchTest.java View 22 chunks +22 lines, -22 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/QuasiBuilderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/RewriterTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ScopeTest.java View 20 chunks +31 lines, -28 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/TamingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ValijaModuleLoadingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/CssRewriterTest.java View 11 chunks +16 lines, -16 lines 0 comments Download
M tests/com/google/caja/plugin/CssRuleRewriterTest.java View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 24 chunks +26 lines, -26 lines 0 comments Download
M tests/com/google/caja/plugin/DomitaTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/ExpressionSanitizerTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/HtmlCompiledPluginTest.java View 7 chunks +10 lines, -10 lines 0 comments Download
M tests/com/google/caja/plugin/HtmlEmitterTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/JsHtmlSanitizerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/stages/DebuggingSymbolsStageTest.java View 12 chunks +14 lines, -14 lines 0 comments Download
M tests/com/google/caja/plugin/stages/InlineCssImportsStageTest.java View 5 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/plugin/stages/OpenTemplateStageTest.java View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/plugin/stages/RewriteHtmlStageTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/templates/RenamingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateCompilerTest.java View 18 chunks +22 lines, -22 lines 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java View 7 chunks +21 lines, -21 lines 0 comments Download
M tests/com/google/caja/render/CssPrettyPrinterTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/render/JsLinePreservingPrinterTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/render/JsMinimalPrinterTest.java View 6 chunks +22 lines, -22 lines 0 comments Download
M tests/com/google/caja/render/JsPrettyPrinterTest.java View 12 chunks +21 lines, -21 lines 0 comments Download
M tests/com/google/caja/render/SideBySideRendererTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/render/SourceSnippetRendererTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/render/SourceSpansRendererTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/render/TokenClassificationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/reporting/AbstractMessageQueueTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/reporting/BuildInfoTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/reporting/HtmlSnippetProducerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/reporting/SnippetProducerTest.java View 9 chunks +11 lines, -11 lines 0 comments Download
M tests/com/google/caja/service/CajolingServiceTest.java View 7 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/service/ContentTypeCheckTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/util/AbbreviatorTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/util/CapturingReaderTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/util/JoinTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/util/RhinoAssertsTest.java View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/com/google/caja/util/SparseBitSetTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/util/StringsTest.java View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 8 months ago (2009-07-23 00:24:10 UTC) #1
MikeSamuel
http://codereview.appspot.com/97073/diff/1/40 File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java (right): http://codereview.appspot.com/97073/diff/1/40#newcode393 Line 393: // overridden in subclasses. codereview.appspot.com always shows the ...
16 years, 8 months ago (2009-07-23 00:26:34 UTC) #2
metaweta
16 years, 8 months ago (2009-07-23 01:55:22 UTC) #3 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b