Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 97047: Fixes some Eclipse complaints and 1076 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by metaweta
Modified:
16 years, 10 months ago
Reviewers:
MikeSamuel, MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Removes the cast to Object in canReadRev so that 'length' in '123' throws a TypeError properly.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/com/google/caja/parser/js/CajoledModuleExpression.java View 1 chunk +0 lines, -3 lines 0 comments Download
M src/com/google/caja/valija-cajita.js View 1 chunk +1 line, -1 line 1 comment Download
M tests/com/google/caja/parser/quasiliteral/CajitaRewriterTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
metaweta
16 years, 10 months ago (2009-07-21 00:44:45 UTC) #1
MikeSamuel
LGTM Should we consider making all test methods final so that they can't be unintentionally ...
16 years, 10 months ago (2009-07-22 22:11:01 UTC) #2
MikeSamuel
On 2009/07/22 22:11:01, MikeSamuel wrote: > LGTM > > Should we consider making all test ...
16 years, 10 months ago (2009-07-22 22:11:30 UTC) #3
metaweta
16 years, 10 months ago (2009-07-22 22:13:04 UTC) #4
On 2009/07/22 22:11:01, MikeSamuel wrote:
\> http://codereview.appspot.com/97047/diff/1/5#newcode450
> Line 450: if (name in obj) { return true; }
> So this is the significant change?

Yes, this is the significant one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b