On 2009/07/22 22:11:01, MikeSamuel wrote: > LGTM > > Should we consider making all test ...
16 years, 10 months ago
(2009-07-22 22:11:30 UTC)
#3
On 2009/07/22 22:11:01, MikeSamuel wrote:
> LGTM
>
> Should we consider making all test methods final so that they can't be
> unintentionally overridden?
I didn't mean to suggest that that should happen in this change.
> http://codereview.appspot.com/97047/diff/1/5
> File src/com/google/caja/valija-cajita.js (right):
>
> http://codereview.appspot.com/97047/diff/1/5#newcode450
> Line 450: if (name in obj) { return true; }
> So this is the significant change?
Issue 97047: Fixes some Eclipse complaints and 1076
(Closed)
Created 16 years, 10 months ago by metaweta
Modified 16 years, 10 months ago
Reviewers: MarkM, MikeSamuel
Base URL: http://google-caja.googlecode.com/svn/trunk/
Comments: 1