Issue 970041: code review 970041: utf16: add DecodeRune, EncodeRune

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 970041: code review 970041: utf16: add DecodeRune, EncodeRune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 970041: utf16: add DecodeRune, EncodeRune #

Total comments: 3

Patch Set 3 : code review 970041: utf16: add DecodeRune, EncodeRune #

Total comments: 1

Patch Set 4 : code review 970041: utf16: add DecodeRune, EncodeRune #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -4 lines)			Patch
	M	src/pkg/utf16/utf16.go	View	1 2	3 chunks	+31 lines, -4 lines	0 comments	Download
	M	src/pkg/utf16/utf16_test.go	View	1 2	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-21 22:58:46 UTC) #1

http://codereview.appspot.com/970041/diff/2001/3001 File src/pkg/utf16/utf16.go (right): http://codereview.appspot.com/970041/diff/2001/3001#newcode12 src/pkg/utf16/utf16.go:12: // 0xdc00-0xe000 encodes the low 10 bits of a ...

14 years, 11 months ago (2010-04-21 23:05:30 UTC) #2

rsc

PTAL > maybe treat the guys like runeself and make them <= maybe but then ...

14 years, 11 months ago (2010-04-21 23:13:30 UTC) #3

LGTM http://codereview.appspot.com/970041/diff/7001/8001 File src/pkg/utf16/utf16.go (right): http://codereview.appspot.com/970041/diff/7001/8001#newcode39 src/pkg/utf16/utf16.go:39: // EncodeRune returns U+FFFD, U+FFFD. i'm not sure ...

14 years, 11 months ago (2010-04-21 23:18:30 UTC) #4

rsc

14 years, 11 months ago (2010-04-21 23:27:21 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=b836295099f1 ***

utf16: add DecodeRune, EncodeRune

R=r
CC=golang-dev
http://codereview.appspot.com/970041

Expand All Messages | Collapse All Messages