Moin2 test cases ported to Python 2.7 >= 3.3

Moin2 test cases ported to Python 2.7 >= 3.3

Need some changes with pillow >=2.0 in  test_Content.py

[Thomas.J.Waldmann, 2013-05-24 20:06:41]

in general:
before fixing text/binary, it needs to be clear what it should be. same for
StringIO.

some stuff I noted need to get fixed at multiple places, even if i noted it only
once.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/_tests/ldap_testbase.py
File MoinMoin/_tests/ldap_testbase.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/_tests/ldap_testbase.p...
MoinMoin/_tests/ldap_testbase.py:47: from six import StringIO
in the previous file, you used from io import StringIO

https://codereview.appspot.com/9695043/diff/1/MoinMoin/apps/frontend/_tests/t...
File MoinMoin/apps/frontend/_tests/test_frontend.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/apps/frontend/_tests/t...
MoinMoin/apps/frontend/_tests/test_frontend.py:27: print('%s %s' % (method,
url_for(viewname, **viewopts)))
that doesn't work in python 2 if you don't do the required future import.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test__args_wiki.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test__args_wiki.py:14: six.u(r'both positional
both=foo keyword=bar'),
you never need six.u (or six.b) if we require 2.6/2.7/3.3.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test__args_wiki.py:24: six.u(r'''"a b\tc\nd" k="a
b\tc\nd"'''),
use u'''...\\...'''

https://codereview.appspot.com/9695043/diff/1/MoinMoin/converter/_tests/test_...
File MoinMoin/converter/_tests/test_html_out.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/converter/_tests/test_...
MoinMoin/converter/_tests/test_html_out.py:50: tree =
etree.parse(six.StringIO(string_to_parse))
here it is six.StringIO, above it is StringIO.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/datastruct/backends/_t...
File MoinMoin/datastruct/backends/_tests/__init__.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:48: for group, members in
six.iteritems(self.expanded_groups):
why?

https://codereview.appspot.com/9695043/diff/1/MoinMoin/datastruct/backends/_t...
MoinMoin/datastruct/backends/_tests/__init__.py:64: for group, members in
six.iteritems(self.expanded_groups):
why?

https://codereview.appspot.com/9695043/diff/1/MoinMoin/items/_tests/test_Cont...
File MoinMoin/items/_tests/test_Content.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/items/_tests/test_Cont...
MoinMoin/items/_tests/test_Content.py:152: assert
(six.binary_type(result).startswith('<img src="/+diffraw/image_Item?rev') or
that's inconsistent.
binary type vs. text type

https://codereview.appspot.com/9695043/diff/1/MoinMoin/items/_tests/test_Cont...
MoinMoin/items/_tests/test_Content.py:153:
six.binary_type(result).startswith('<img src="/%2Bdiffraw/image_Item?rev'))
same

https://codereview.appspot.com/9695043/diff/1/MoinMoin/mail/_tests/test_sendm...
File MoinMoin/mail/_tests/test_sendmail.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/mail/_tests/test_sendm...
MoinMoin/mail/_tests/test_sendmail.py:96: expected = six.binary_type(address)
not sure whether binary_type is correct here.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/middleware/_te...
File MoinMoin/storage/middleware/_tests/test_indexing.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/middleware/_te...
MoinMoin/storage/middleware/_tests/test_indexing.py:11: from six import StringIO
for "textual data"

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/middleware/_te...
MoinMoin/storage/middleware/_tests/test_indexing.py:375:
StringIO(six.binary_type(item_name_n)), return_rev=True)
and here you give binary data to it, that will crash on py3

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/middleware/_te...
MoinMoin/storage/middleware/_tests/test_indexing.py:379:
StringIO(six.binary_type(item_name_u)), return_rev=True)
same

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/stores/_tests/...
File MoinMoin/storage/stores/_tests/conftest.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/stores/_tests/...
MoinMoin/storage/stores/_tests/conftest.py:38: 'kc': lambda store, tmpdir:
store(six.binary_type(tmpdir.join('store.kch'))),
not sure if that is correct.

on python2, i just used str because unicode pathes make some functions behave
differently.

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/stores/_tests/...
File MoinMoin/storage/stores/_tests/test_all.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/storage/stores/_tests/...
MoinMoin/storage/stores/_tests/test_all.py:68: del store[key]
the key is expected to be ascii text, the value is binary

https://codereview.appspot.com/9695043/diff/1/MoinMoin/util/_tests/test_inter...
File MoinMoin/util/_tests/test_interwiki.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/util/_tests/test_inter...
MoinMoin/util/_tests/test_interwiki.py:190: testfile = os.path.join(abspath,
'contrib', 'interwiki', 'intermap.txt')
don't change lines without need

https://codereview.appspot.com/9695043/diff/1/MoinMoin/util/_tests/test_versi...
File MoinMoin/util/_tests/test_version.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/util/_tests/test_versi...
MoinMoin/util/_tests/test_version.py:27: assert
six.binary_type(Version(version='1.2.3a4')) == "1.2.3a4"
looks rather like text than binary

https://codereview.appspot.com/9695043/diff/1/_ui_tests/utils.py
File _ui_tests/utils.py (right):

https://codereview.appspot.com/9695043/diff/1/_ui_tests/utils.py#newcode23
_ui_tests/utils.py:23: f = urllib.urlopen(config.BASE_URL)
no

[chitrankdixit, 2013-05-24 21:11:15]

https://codereview.appspot.com/9695043/diff/1/MoinMoin/_tests/ldap_testbase.py
File MoinMoin/_tests/ldap_testbase.py (right):

https://codereview.appspot.com/9695043/diff/1/MoinMoin/_tests/ldap_testbase.p...
MoinMoin/_tests/ldap_testbase.py:47: from six import StringIO
On 2013/05/24 20:06:42, Thomas.J.Waldmann wrote:
> in the previous file, you used from io import StringIO

Done.