charmstore: Return several events for one charm

charmstore: Return several events for one charm

Currently, requests to the "event" endpoint asking for data about two
or more events of one charm get only information about one event back.

This patch allows to optionally retrieve information about several events
in one request.

https://code.launchpad.net/~adeuring/juju-core/charmstore-multiple-events-per-charm/+merge/217951

(do not edit description out of merge proposal)

[abel.deuring, 2014-05-01 17:13:12]

Please take a look.

[dimitern, 2014-05-01 17:19:59]

LGTM with a few minor suggestions.

https://codereview.appspot.com/96950043/diff/1/store/server.go
File store/server.go (right):

https://codereview.appspot.com/96950043/diff/1/store/server.go#newcode148
store/server.go:148: short_url := url
I'd prefer shortURL for consistency sake.

https://codereview.appspot.com/96950043/diff/1/store/server.go#newcode155
store/server.go:155: if r.Form.Get("long_keys") != "1" {
Please, add a comment here describing what we're doing because it's not very
obvious.

https://codereview.appspot.com/96950043/diff/1/store/server_test.go
File store/server_test.go (right):

https://codereview.appspot.com/96950043/diff/1/store/server_test.go#newcode187
store/server_test.go:187: event1_info := map[string]interface{}{
s/event#_info/event#Info/ everywhere please.

https://codereview.appspot.com/96950043/diff/1/store/server_test.go#newcode207
store/server_test.go:207: c.Assert(obtained, gc.DeepEquals, expected)
It might be a good idea to use jc.DeepEquals here and below on line 216, because
it gives a better error message on failure.