Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 969046: Don't hardcode a limited set of markup signatures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by dak
Modified:
8 years, 2 months ago
Reviewers:
nicolas.sceaux, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't hardcode a limited set of markup signatures.

Patch Set 1 #

Patch Set 2 : Clean the signature tokenizer a bit. #

Total comments: 3

Patch Set 3 : Add some comments to the markup signature tokenizer. #

Total comments: 3

Patch Set 4 : Check markup command signatures at definition time. #

Patch Set 5 : Remove order restrictions on markup command arguments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -191 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 3 4 1 chunk +13 lines, -46 lines 0 comments Download
M lily/lexer.ll View 1 2 3 4 2 chunks +47 lines, -52 lines 0 comments Download
M lily/parser.yy View 1 2 3 4 5 chunks +27 lines, -58 lines 0 comments Download
M scm/markup.scm View 4 3 chunks +5 lines, -35 lines 0 comments Download

Messages

Total messages: 8
hanwenn
just a quick look http://codereview.appspot.com/969046/diff/2001/3002 File lily/lexer.ll (right): http://codereview.appspot.com/969046/diff/2001/3002#newcode542 lily/lexer.ll:542: yylval.scm = scm_car(s); can you ...
9 years, 1 month ago (2010-05-01 17:13:30 UTC) #1
dak
http://codereview.appspot.com/969046/diff/2001/3002 File lily/lexer.ll (right): http://codereview.appspot.com/969046/diff/2001/3002#newcode542 lily/lexer.ll:542: yylval.scm = scm_car(s); On 2010/05/01 17:13:32, hanwenn wrote: > ...
9 years, 1 month ago (2010-05-01 17:50:12 UTC) #2
hanwenn
http://codereview.appspot.com/969046/diff/7001/8002 File lily/lexer.ll (right): http://codereview.appspot.com/969046/diff/7001/8002#newcode545 lily/lexer.ll:545: // loop will be EXPECT_NO_MORE_ARGS. wouldnt it be clearer ...
9 years, 1 month ago (2010-05-01 19:56:08 UTC) #3
dak
http://codereview.appspot.com/969046/diff/7001/8002 File lily/lexer.ll (right): http://codereview.appspot.com/969046/diff/7001/8002#newcode545 lily/lexer.ll:545: // loop will be EXPECT_NO_MORE_ARGS. On 2010/05/01 19:56:08, hanwenn ...
9 years, 1 month ago (2010-05-02 11:04:55 UTC) #4
hanwenn
On Sun, May 2, 2010 at 8:04 AM, <dak@gnu.org> wrote: > > http://codereview.appspot.com/969046/diff/7001/8002 > File ...
9 years, 1 month ago (2010-05-02 16:34:12 UTC) #5
dak
On 2010/05/02 16:34:12, hanwenn wrote: > On Sun, May 2, 2010 at 8:04 AM, <mailto:dak@gnu.org> ...
9 years, 1 month ago (2010-05-03 08:22:24 UTC) #6
dak
Another patch set has been made that removes the order restrictions on the markup function ...
9 years, 1 month ago (2010-05-15 23:43:35 UTC) #7
nicolas.sceaux
9 years, 1 month ago (2010-05-16 09:30:38 UTC) #8
Looks good!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b