src/pkg/net/http/transport_test.go - Issue 96850043: code review 96850043: src: fix issues found by go vet std

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/net/http/transport_test.go

Issue 96850043: code review 96850043: src: fix issues found by go vet std (Closed)

Patch Set: diff -r e141dda580af https://code.google.com/p/go Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/net/http/transport_test.go

===================================================================

--- a/src/pkg/net/http/transport_test.go

+++ b/src/pkg/net/http/transport_test.go

@@ -1412,7 +1412,6 @@

case <-gotres:

case <-time.After(5 * time.Second):

panic("hang. events are: " + logbuf.String())

- t.Fatal("timeout; cancel didn't work?")

}

got := logbuf.String()

@@ -1869,10 +1868,10 @@

return

}

if !ne.Timeout() {

- t.Error("expected timeout error; got %v", err)

+ t.Errorf("expected timeout error; got %v", err)

}

if !strings.Contains(err.Error(), "handshake timeout") {

- t.Error("expected 'handshake timeout' in error; got %v", err)

+ t.Errorf("expected 'handshake timeout' in error; got %v", err)

}

}()

select {

« no previous file with comments | « src/pkg/net/http/serve_test.go ('k') | no next file » | no next file with comments »