code review 968042: FileInfo: regularize the types of some fields.

FileInfo: regularize the types of some fields.
Uid, Gid become int.
File size info becomes int64.
Times become int64.

[r, 2010-04-22 20:34:33]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[cw, 2010-04-22 20:50:26]

LG

http://codereview.appspot.com/968042/diff/5001/6001
File src/pkg/archive/tar/common.go (left):

http://codereview.appspot.com/968042/diff/5001/6001#oldcode35
src/pkg/archive/tar/common.go:35: Mode     int64
Does this really need to be 64-bits?

http://codereview.appspot.com/968042/diff/5001/6001
File src/pkg/archive/tar/common.go (right):

http://codereview.appspot.com/968042/diff/5001/6001#newcode39
src/pkg/archive/tar/common.go:39: Mtime    int64
The units here are seconds since epoch.

The time package uses nanoseconds.


Is this something we should consider addressing?

Either:
 - document it as such, get over the differences
 - pick a preferred form, leave as int64
 - create a new type and have mechanism to use that cleanly

[rsc, 2010-04-22 21:00:51]

LGTM

[r, 2010-04-22 21:01:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=08c8a3dfeef2 ***

FileInfo: regularize the types of some fields.
Uid, Gid become int.
File size info becomes int64.
Times become int64.

R=rsc, cw
CC=golang-dev
http://codereview.appspot.com/968042

[r2, 2010-04-22 21:03:27]

apologies; submitted before i saw this message.

On Apr 22, 2010, at 1:50 PM, cw@f00f.org wrote:

> LG
>
>
> http://codereview.appspot.com/968042/diff/5001/6001
> File src/pkg/archive/tar/common.go (left):
>
> http://codereview.appspot.com/968042/diff/5001/6001#oldcode35
> src/pkg/archive/tar/common.go:35: Mode     int64
> Does this really need to be 64-bits?

it's 64 bits on some operating systems, so it seemed safe to keep the  
bits available in case they're used by someone.

> http://codereview.appspot.com/968042/diff/5001/6001
> File src/pkg/archive/tar/common.go (right):
>
> http://codereview.appspot.com/968042/diff/5001/6001#newcode39
> src/pkg/archive/tar/common.go:39: Mtime    int64
> The units here are seconds since epoch.
>
> The time package uses nanoseconds.

that's up to the package's author.

> Is this something we should consider addressing?
>
> Either:
> - document it as such, get over the differences
> - pick a preferred form, leave as int64
> - create a new type and have mechanism to use that cleanly

i await discussion. if anything happens it should be part of a  
separate CL because it's an unrelated issue.

-rob