Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(641)

Issue 96600043: state/apiserver/root.go: cache active facades

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jameinel
Modified:
9 years, 11 months ago
Reviewers:
mp+220937, dimitern
Visibility:
Public.

Description

state/apiserver/root.go: cache active facades Since I made Client no longer special, it was now being created again for every request, which is a bit inefficient. However, since we now have a centralized location where requests go through, it is pretty easy to add caching there. And now all Facades are cached. It even comes with a test that we don't create new objects for the same (Name, version) couple, but we do create a different one when version changes. https://code.launchpad.net/~jameinel/juju-core/cache-facade-instances/+merge/220937 Requires: https://code.launchpad.net/~jameinel/juju-core/api-srvRoot-ensures-type/+merge/220615 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/export_test.go View 1 chunk +5 lines, -4 lines 0 comments Download
M state/apiserver/root.go View 3 chunks +40 lines, -24 lines 0 comments Download
M state/apiserver/root_test.go View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
9 years, 11 months ago (2014-05-26 10:15:24 UTC) #1
dimitern
9 years, 11 months ago (2014-05-26 10:42:59 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b