Issue 96540047: worker: actually fix simpleworker Kill

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96540047: worker: actually fix simpleworker Kill

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by axw

Modified:
11 years, 9 months ago

Reviewers:
mp+220583, fwereade, wallyworld

Visibility:
Public.

Description

worker: actually fix simpleworker Kill I broke the simple worker's contract w.r.t. the stop channel; this fixes it. https://code.launchpad.net/~axwalk/juju-core/worker-simple-kill/+merge/220583 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : worker: actually fix simpleworker Kill #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/simpleworker.go	View	1	2 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

I feel like life would be easier if we just used tomb for all these ...

11 years, 9 months ago (2014-05-22 11:40:02 UTC) #2

axw

Please take a look. https://codereview.appspot.com/96540047/diff/1/worker/simpleworker.go File worker/simpleworker.go (right): https://codereview.appspot.com/96540047/diff/1/worker/simpleworker.go#newcode46 worker/simpleworker.go:46: close(w.stopc) On 2014/05/22 11:40:01, fwereade ...

11 years, 9 months ago (2014-05-22 12:44:30 UTC) #3

LGTM

Expand All Messages | Collapse All Messages