Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 9638047: Fix NO_NETWORK policy causing guests to lose progress; don't fetch example.com. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* caja.policy.net.NO_NETWORK.fetch now invokes its callback rather than ignoring it. Fixes <https://code.google.com/p/google-caja/issues/detail?id=1579>. * test-cajajs-invocation testBuilderApiNetNone checks that <script src> and XHR fail sensibly under NO_NETWORK. * In default test driver, use domain "caja-test-url.test" instead of "example.com" for rewriting, and don't fetch any such urls if they go to the fetcher (not all do). The TLD ".test" is reserved by RFC 2606. Fixes <https://code.google.com/p/google-caja/issues/detail?id=1680>. @r5419

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M src/com/google/caja/plugin/caja.js View 1 chunk +6 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/default-test-driver.js View 2 chunks +9 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-cajajs-invocation.js View 1 chunk +24 lines, -5 lines 1 comment Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 9 months ago (2013-05-22 22:03:33 UTC) #1
ihab.awad
12 years, 9 months ago (2013-05-22 23:18:23 UTC) #2
lgtm

https://codereview.appspot.com/9638047/diff/1/tests/com/google/caja/plugin/es...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

https://codereview.appspot.com/9638047/diff/1/tests/com/google/caja/plugin/es...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:287: 'try {
xhr.open("http://localhost/"); } catch (e) { r(""+e); }' +
nit: space around "+" operator.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b