Issue 962046: code review 962046: properly handle eof while reading stdin in mingw syscal...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 962046: code review 962046: properly handle eof while reading stdin in mingw syscal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by brainman

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

properly handle eof while reading stdin in mingw syscall.Read

Patch Set 1 #

Patch Set 2 : code review 962046: properly handle eof while reading stdin in mingw syscal... #

Patch Set 3 : code review 962046: properly handle eof while reading stdin in mingw syscal... #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/pkg/syscall/syscall_windows.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/syscall/zerrors_windows_386.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 10 months ago (2010-04-28 07:00:44 UTC) #1

brainman

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 10 months ago (2010-04-30 07:01:40 UTC) #2

rsc

14 years, 10 months ago (2010-04-30 19:46:48 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=dde9a4a3f5dd ***

syscall: handle EOF on pipe - special case on Windows

R=rsc
CC=golang-dev
http://codereview.appspot.com/962046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages