LGTM On Apr 22, 2010, at 4:18 PM, adg@golang.org wrote: > Reviewers: rsc, > > ...
14 years, 11 months ago
(2010-04-22 23:19:23 UTC)
#3
LGTM
On Apr 22, 2010, at 4:18 PM, adg@golang.org wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> go_faq: typo fix
>
> Please review this at http://codereview.appspot.com/962043/show
>
> Affected files:
> M doc/go_faq.html
>
>
> Index: doc/go_faq.html
> ===================================================================
> --- a/doc/go_faq.html
> +++ b/doc/go_faq.html
> @@ -363,7 +363,7 @@
>
> <p>
> Still, there is room for improvement. The compilers are good but
> could be
> -better, many librarise need major performance work, and the garbage
> collector
> +better, many libraries need major performance work, and the garbage
> collector
> isn't fast enough yet (even if it were, taking care not to generate
> unnecessary
> garbage can have a huge effect).
> </p>
>
>
>
>
> --
> Subscription settings:
http://groups.google.com/group/golang-dev/subscribe?hl=en
LGTM On Thu, Apr 22, 2010 at 4:18 PM, <adg@golang.org> wrote: > Reviewers: rsc, > ...
14 years, 11 months ago
(2010-04-22 23:19:52 UTC)
#4
LGTM
On Thu, Apr 22, 2010 at 4:18 PM, <adg@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> go_faq: typo fix
>
> Please review this at http://codereview.appspot.com/962043/show
>
> Affected files:
> M doc/go_faq.html
>
>
> Index: doc/go_faq.html
> ===================================================================
> --- a/doc/go_faq.html
> +++ b/doc/go_faq.html
> @@ -363,7 +363,7 @@
>
> <p>
> Still, there is room for improvement. The compilers are good but could be
> -better, many librarise need major performance work, and the garbage
> collector
> +better, many libraries need major performance work, and the garbage
> collector
> isn't fast enough yet (even if it were, taking care not to generate
> unnecessary
> garbage can have a huge effect).
> </p>
>
>
>
>
> --
> Subscription settings:
> http://groups.google.com/group/golang-dev/subscribe?hl=en
>
Well, I'm glad I was able to get consensus for this controversial change. On 23 ...
14 years, 11 months ago
(2010-04-23 00:01:16 UTC)
#5
Well, I'm glad I was able to get consensus for this controversial change.
On 23 April 2010 09:19, Robert Griesemer <gri@google.com> wrote:
> LGTM
>
> On Thu, Apr 22, 2010 at 4:18 PM, <adg@golang.org> wrote:
>>
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change.
>>
>>
>> Description:
>> go_faq: typo fix
>>
>> Please review this at http://codereview.appspot.com/962043/show
>>
>> Affected files:
>> M doc/go_faq.html
>>
>>
>> Index: doc/go_faq.html
>> ===================================================================
>> --- a/doc/go_faq.html
>> +++ b/doc/go_faq.html
>> @@ -363,7 +363,7 @@
>>
>> <p>
>> Still, there is room for improvement. The compilers are good but could be
>> -better, many librarise need major performance work, and the garbage
>> collector
>> +better, many libraries need major performance work, and the garbage
>> collector
>> isn't fast enough yet (even if it were, taking care not to generate
>> unnecessary
>> garbage can have a huge effect).
>> </p>
>>
>>
>>
>>
>> --
>> Subscription settings:
>> http://groups.google.com/group/golang-dev/subscribe?hl=en
>
>
Issue 962043: code review 962043: go_faq: typo fix
(Closed)
Created 14 years, 11 months ago by adg
Modified 14 years, 11 months ago
Reviewers:
Base URL:
Comments: 0