Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 96198: Enhance handling of forms (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by ihab.awad
Modified:
16 years, 9 months ago
Reviewers:
felix8a, MikeSamuel, Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Fix the following bugs: http://code.google.com/p/google-caja/issues/detail?id=1064 http://code.google.com/p/google-caja/issues/detail?id=1091 * Make the Domita tests use eval() to run code, allowing the eval()-d source to be seen by the debugger in Firefox. (Using new Function() or adding a <script> node both cloak the code from the debugger.) * Add initial support to DomitaTest to report what elements caused out-of-bounds clicking or waiting to happen. * In the process, refactored Domita's taming of NodeList and HTMLCollection objects a bit. * Refactored the testbed HTML so that it does not put the rendering of the cajoled stuff in a big <form>. This is because nested <form>s are not really supported, and so if the cajoled stuff itself contained a <form> node, things would break. * Changed the testbed to use the un-minified JS files, thus making it easier to debug.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Enhance handling of forms #

Total comments: 1

Patch Set 3 : Enhance handling of forms #

Patch Set 4 : Enhance handling of forms #

Patch Set 5 : Enhance handling of forms #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -75 lines) Patch
M src/com/google/caja/demos/applet/index.html View 1 2 6 chunks +25 lines, -10 lines 0 comments Download
M src/com/google/caja/demos/applet/testbed.js View 1 2 3 4 chunks +22 lines, -15 lines 0 comments Download
M src/com/google/caja/plugin/domita.js View 1 2 6 chunks +137 lines, -39 lines 0 comments Download
M tests/com/google/caja/plugin/DomitaTest.java View 1 2 4 chunks +32 lines, -6 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 2 2 chunks +91 lines, -0 lines 0 comments Download
M tools/myvn View 3 chunks +4 lines, -4 lines 3 comments Download

Messages

Total messages: 8
ihab.awad
16 years, 10 months ago (2009-07-31 00:43:27 UTC) #1
felix8a
http://codereview.appspot.com/96198/diff/1/7 File src/com/google/caja/demos/applet/index.html (right): http://codereview.appspot.com/96198/diff/1/7#newcode111 Line 111: <!-- <script type="text/javascript" src="cajita-combined-min.js"></script> --> if you're going ...
16 years, 10 months ago (2009-07-31 00:56:35 UTC) #2
Jasvir
LGTM http://codereview.appspot.com/96198/diff/1008/10 File tests/com/google/caja/plugin/domita_test.html (right): http://codereview.appspot.com/96198/diff/1008/10#newcode183 Line 183: eval(htmlAndScript[2]); Note: Eval'ed code shows up correctly ...
16 years, 9 months ago (2009-08-17 11:54:39 UTC) #3
ihab.awad
Mike Samuel, please review changes to tools/myvn.
16 years, 9 months ago (2009-08-26 00:30:23 UTC) #4
MikeSamuel
http://codereview.appspot.com/96198/diff/3006/4018 File tools/myvn (right): http://codereview.appspot.com/96198/diff/3006/4018#newcode115 Line 115: runAntTests "$@" && "$svn" commit -F <("$tools_dir/appspot.py" show) ...
16 years, 9 months ago (2009-08-26 00:33:22 UTC) #5
ihab.awad
http://codereview.appspot.com/96198/diff/3006/4018 File tools/myvn (right): http://codereview.appspot.com/96198/diff/3006/4018#newcode115 Line 115: runAntTests "$@" && "$svn" commit -F <("$tools_dir/appspot.py" show) ...
16 years, 9 months ago (2009-08-26 00:36:45 UTC) #6
ihab.awad
http://codereview.appspot.com/96198/diff/3006/4018 File tools/myvn (right): http://codereview.appspot.com/96198/diff/3006/4018#newcode115 Line 115: runAntTests "$@" && "$svn" commit -F <("$tools_dir/appspot.py" show) ...
16 years, 9 months ago (2009-08-26 17:03:19 UTC) #7
ihab.awad
16 years, 9 months ago (2009-08-26 17:03:42 UTC) #8
@3657
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b