Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 9617043: Remove "testNop"s and recognize skipped tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Remove "testNop"s from test files with skipped tests. * jsunit.js doesn't die if all tests are skipped. * Meta tests for no tests or only skipped tests. @r5415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M tests/com/google/caja/plugin/es53-test-css-imports-guest.html View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-external-script-guest.html View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-inline-script.html View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/jsunit.js View 3 chunks +3 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/meta-test.js View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/com/google/caja/plugin/meta-test-no-tests.js View 1 chunk +22 lines, -0 lines 0 comments Download
A tests/com/google/caja/plugin/meta-test-skipped-test.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 9 months ago (2013-05-21 18:25:55 UTC) #1
felix8a
12 years, 9 months ago (2013-05-21 18:55:59 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b