Issue 96153: Fix binding of $dis for event listeners

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96153: Fix binding of $dis for event listeners (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 10 months ago by metaweta

Modified:
16 years, 10 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fixes issue 1089. The keyword "this" gets rewritten to "thisNode___" in an onclick attribute, but to "$dis" in a valija function. We were invoking valija event listeners with "$dis" bound to USELESS.

Patch Set 1 #

Created: 16 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	src/com/google/caja/plugin/domita.js	View		1 chunk	+4 lines, -5 lines	0 comments	Download
	M	tests/com/google/caja/plugin/domita_test_untrusted.html	View		2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

On 2009/07/25 03:16:17, felix8a wrote:
> lgtm

@3610

Expand All Messages | Collapse All Messages