Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 96153: Fix binding of $dis for event listeners (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by metaweta
Modified:
16 years, 10 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes issue 1089. The keyword "this" gets rewritten to "thisNode___" in an onclick attribute, but to "$dis" in a valija function. We were invoking valija event listeners with "$dis" bound to USELESS.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M src/com/google/caja/plugin/domita.js View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
metaweta
16 years, 10 months ago (2009-07-25 00:56:52 UTC) #1
felix8a
lgtm
16 years, 10 months ago (2009-07-25 03:16:17 UTC) #2
metaweta
16 years, 10 months ago (2009-07-26 07:28:25 UTC) #3
On 2009/07/25 03:16:17, felix8a wrote:
> lgtm

@3610
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b