Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 96083: SVG backend: On-the-fly conversion of Emmentaler/Aybabtu glyphs to paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by Patrick McCarty
Modified:
9 years, 9 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

SVG backend: On-the-fly conversion of Emmentaler/Aybabtu glyphs to paths - An API change for the word_stencil () function. This serves to filter all Emmentaler/Aybabtu glyphs that pass through the text-interface. - Any output backend that contains "utf-8-string" will use "utf-8-string" instead of "glyph-string". The only exception is the SVG backend, which uses "glyph-string" for text written in a music font and "utf-8-string" for all other text. - Remove obsolete "utf-8-string" from output-ps.scm; warnings are issued upon finding *any* missing/invalid/undefined stencil expression, so this case is already covered. - The appropriate SVG fonts are found, cached, and used to extract the appropriate glyphs for "named-glyph" and "glyph-string" stencil expressions. The glyph path data is then dumped into a <path> element and scaled appropriately.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address Joe's comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -94 lines) Patch
M lily/font-metric.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M lily/font-metric-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/font-metric.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/modified-font-metric.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pango-font.hh View 1 chunk +4 lines, -4 lines 0 comments Download
M lily/modified-font-metric.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/pango-font.cc View 1 2 chunks +22 lines, -7 lines 2 comments Download
M lily/text-interface.cc View 1 1 chunk +16 lines, -1 line 0 comments Download
M scm/font.scm View 1 chunk +9 lines, -0 lines 0 comments Download
M scm/framework-svg.scm View 2 chunks +0 lines, -20 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +12 lines, -10 lines 0 comments Download
M scm/output-ps.scm View 1 chunk +0 lines, -3 lines 0 comments Download
M scm/output-svg.scm View 1 6 chunks +185 lines, -38 lines 0 comments Download

Messages

Total messages: 4
joeneeman
http://codereview.appspot.com/96083/diff/1/8 File lily/pango-font.cc (right): http://codereview.appspot.com/96083/diff/1/8#newcode351 Line 351: // options. Could you please have a look ...
9 years, 10 months ago (2009-07-21 18:43:10 UTC) #1
Patrick McCarty
http://codereview.appspot.com/96083/diff/1/8 File lily/pango-font.cc (right): http://codereview.appspot.com/96083/diff/1/8#newcode351 Line 351: // options. On 2009/07/21 18:43:10, joeneeman wrote: > ...
9 years, 10 months ago (2009-07-24 23:30:00 UTC) #2
joeneeman
On 2009/07/24 23:30:00, Patrick McCarty wrote: > On 2009/07/21 18:43:10, joeneeman wrote: > > I ...
9 years, 9 months ago (2009-07-26 02:03:55 UTC) #3
joeneeman
9 years, 9 months ago (2009-07-26 02:05:34 UTC) #4
It seems as though rietveld wants to send my code-comments and my
reply-to-comments comments in two separate emails. Sorry for the noise.

http://codereview.appspot.com/96083/diff/1015/20
File lily/pango-font.cc (right):

http://codereview.appspot.com/96083/diff/1015/20#newcode354
Line 354: bool has_utf8_string = false;
I like this way of dealing with the ps backend much better...

http://codereview.appspot.com/96083/diff/1015/20#newcode367
Line 367: if ((name == "svg" && !feta) || (name != "svg" && has_utf8_string))
...but I think it would be ideal if the text_stencil code was totally unaware of
the backend (maybe using something like -ddump-music-strings-as-paths, which
defaults to true when -dbackend=svg). I'm not suggesting you do it now, but it
would be nice to have a NOTE or TODO here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b