Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(407)

Issue 96079: Fix changes to caja api calling convention that break caja gadgets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by Jasvir
Modified:
16 years, 6 months ago
CC:
shindig.remailer_gmail.com, google-caja-discuss_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

* removes libs=caja from url params in sample container - the behavior for this appears to have changed in shindig * changes to CajaContentRewriter to ensure error messages from caja are properly escaped * changes to CajaContentRewriter to handle the new static html output

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated to address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M features/src/main/javascript/features/caja/caja.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M features/src/main/javascript/features/opensocial-reference/container.js View 1 1 chunk +1 line, -5 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 1 5 chunks +22 lines, -14 lines 0 comments Download
M javascript/samplecontainer/samplecontainer.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Jasvir
16 years, 7 months ago (2009-07-20 21:28:07 UTC) #1
Paul Lindner
Nothing obviously wrong here. Please create a jira issue and I can apply this patch. ...
16 years, 7 months ago (2009-07-22 20:06:16 UTC) #2
etnu00
http://codereview.appspot.com/96079/diff/1/2 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java (right): http://codereview.appspot.com/96079/diff/1/2#newcode93 Line 93: String origContent = content.getContent(); So this code is ...
16 years, 7 months ago (2009-07-22 20:22:18 UTC) #3
Jasvir
16 years, 7 months ago (2009-07-22 21:22:05 UTC) #4
Snapshot

http://codereview.appspot.com/96079/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/96079/diff/1/2#newcode93
Line 93: String origContent = content.getContent();
Ok.  The next release of Caja will switch to accepting and outputting DOM nodes
directly.

http://codereview.appspot.com/96079/diff/1/2#newcode102
Line 102: Document doc = content.getDocument();
On 2009/07/22 20:22:18, etnu00 wrote:
> These two lines will result yet another parse. content.setContent("") should
be
> removed. If a problem occurs when cajoling, handle it (put it in a finally
block
> if you want to be really sure).

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b