fix some java warnings

with my normal settings, eclipse emits about
half a dozen warnings.  this change fixes them.

[felix8a, 2009-07-20 10:21:21]

just noticed, after fixing a warning, a new test failure is uncovered.
there's a test to check ('length' in '123') throws a type error.
currently, valija doesn't throw an error.
(cajita and native do.)

[ihab.awad, 2009-07-20 23:49:09]

LGTM

http://codereview.appspot.com/96075/diff/8/2010
File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java
(right):

http://codereview.appspot.com/96075/diff/8/2010#newcode53
Line 53: */
Oh oh oh oh oh ... the whole of testIn() was not being run in the case of Valija
since it was getting clobbered by the subclass. Do'owwww! :( Mike Stay is going
to look into this since he was the last one to mess with that stuff.

http://codereview.appspot.com/96075/diff/8/2009
File tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java
(right):

http://codereview.appspot.com/96075/diff/8/2009#newcode541
Line 541: "___.grantFunc(testImports, 'fail');" +
Ah ... so we were running with this undefined and our "fail()-ures" were because
of the undefined symbol, not proper calls to fail()? Wow.

[felix8a, 2009-07-21 21:55:22]

@r3599

http://codereview.appspot.com/96075/diff/8/2010
File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java
(right):

http://codereview.appspot.com/96075/diff/8/2010#newcode53
Line 53: */
On 2009/07/20 23:49:09, ihab.awad wrote:
> Oh oh oh oh oh ... the whole of testIn() was not being run in the case of
Valija
> since it was getting clobbered by the subclass. Do'owwww! :( Mike Stay is
going
> to look into this since he was the last one to mess with that stuff.

I've reinstated this test since Mike Stay has a pending CL to fix it.