Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 959042: SHINDIG-1320 Perform hangman variable substitution on variables with later precedence (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by mat.mannion
Modified:
15 years, 11 months ago
Reviewers:
henry.saputra, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Create precedence in hangman substitution variables and allow previously added substitutions to be used in the values of substitution variables, so user prefs that point to a MSG substitution work.

Patch Set 1 #

Patch Set 2 : Updated patch with suggestions in JIRA from Henry Saputra #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -84 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java View 2 chunks +3 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/BidiSubstituter.java View 1 chunk +37 lines, -20 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/MessageSubstituter.java View 1 chunk +47 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/ModuleSubstituter.java View 1 chunk +32 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/Substituter.java View 1 chunk +40 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/SubstituterModule.java View 1 chunk +61 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/Substitutions.java View 2 chunks +8 lines, -8 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/UserPrefSubstituter.java View 1 chunk +19 lines, -16 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/VariableSubstituter.java View 1 2 chunks +17 lines, -20 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java View 2 chunks +5 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/BidiSubstituterTest.java View 1 chunk +27 lines, -11 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/MessageSubstituterTest.java View 1 chunk +54 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/ModuleSubstituterTest.java View 1 chunk +63 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/UserPrefSubstituterTest.java View 3 chunks +21 lines, -7 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/VariableSubstituterTest.java View 1 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 3
mat.mannion
15 years, 11 months ago (2010-04-21 16:13:14 UTC) #1
mat.mannion
Updated patch with suggestions in JIRA from Henry Saputra
15 years, 11 months ago (2010-04-22 10:13:11 UTC) #2
henry.saputra
15 years, 11 months ago (2010-04-22 18:42:52 UTC) #3
Looks good to me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b