Issue 95550049: Updates due to new Path semantics

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95550049: Updates due to new Path semantics (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rafaelw

Modified:
10 years, 11 months ago

Reviewers:
arv

Base URL:
git@github.com:Polymer/polymer-expressions.git@master

Visibility:
Public.

More Reviews

Description

Updates due to new Path semantics R=arv BUG= Committed: https://github.com/Polymer/polymer-expressions/commit/5cbe711

Patch Set 3 : cr changes #

Total comments: 4

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -17 lines)			Patch
	M	src/polymer-expressions.js	View		3 chunks	+13 lines, -17 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #3 manually as r5cbe711 (presubmit successful).

10 years, 11 months ago (2014-05-23 23:51:47 UTC) #1

arv

https://codereview.appspot.com/95550049/diff/40001/src/polymer-expressions.js File src/polymer-expressions.js (right): https://codereview.appspot.com/95550049/diff/40001/src/polymer-expressions.js#newcode120 src/polymer-expressions.js:120: this.object.fullPath.slice() : [ this.object.name ]; no spaces inside literals ...

10 years, 11 months ago (2014-05-24 00:40:24 UTC) #2

rafaelw

10 years, 11 months ago (2014-05-24 00:44:55 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/95550049/diff/40001/src/polymer-expressions.js
File src/polymer-expressions.js (right):

https://codereview.appspot.com/95550049/diff/40001/src/polymer-expressions.js...
src/polymer-expressions.js:120: this.object.fullPath.slice() : [
this.object.name ];
On 2014/05/24 00:40:24, arv wrote:
> no spaces inside literals

Done.

https://codereview.appspot.com/95550049/diff/40001/src/polymer-expressions.js...
src/polymer-expressions.js:161: observer.addPath(context, [propName]);
Yes. That makes it's a "path literal". It means we can avoid needing to
serialize & possibly escape quote characters.

On 2014/05/24 00:40:24, arv wrote:
> is this array needed?

Expand All Messages | Collapse All Messages