Synchronous API to get a Rule for a LookupKey.

Synchronous API to get a Rule for a LookupKey.

R=lararennie@google.com

Committed: https://code.google.com/p/libaddressinput/source/detail?r=243

[Rouslan Solomakhin, 2014-05-23 07:20:02]

Lara: PTAL Patch Set 1.

[lararennie, 2014-05-23 07:37:59]

As discussed, could be better to just look in cache.

https://codereview.appspot.com/95550047/diff/1/cpp/test/preload_supplier_test.cc
File cpp/test/preload_supplier_test.cc (right):

https://codereview.appspot.com/95550047/diff/1/cpp/test/preload_supplier_test...
cpp/test/preload_supplier_test.cc:98: 
I think a test for a rule we don't have would be better.

[Rouslan Solomakhin, 2014-05-23 07:58:47]

Lara: PTAL Patch Set 2. I've simplified the implementation as you suggested and
removed some extra changes that were not necessary in this patch. (They leaked
through from another patch I'm working on.)

https://codereview.appspot.com/95550047/diff/1/cpp/test/preload_supplier_test.cc
File cpp/test/preload_supplier_test.cc (right):

https://codereview.appspot.com/95550047/diff/1/cpp/test/preload_supplier_test...
cpp/test/preload_supplier_test.cc:98: 
On 2014/05/23 07:37:59, lararennie wrote:
> I think a test for a rule we don't have would be better.

Done.

[lararennie, 2014-05-23 08:04:45]

LGTM, thanks

https://codereview.appspot.com/95550047/diff/60001/cpp/test/preload_supplier_...
File cpp/test/preload_supplier_test.cc (right):

https://codereview.appspot.com/95550047/diff/60001/cpp/test/preload_supplier_...
cpp/test/preload_supplier_test.cc:108: unknown_address.administrative_area =
"ZZ";
And it'd be the same if we loaded rules for US/CA, and then asked for
US/CA/Mountain View, right?

[Rouslan Solomakhin, 2014-05-23 08:08:23]

On 2014/05/23 08:04:45, lararennie wrote:
> LGTM, thanks
> 
>
https://codereview.appspot.com/95550047/diff/60001/cpp/test/preload_supplier_...
> File cpp/test/preload_supplier_test.cc (right):
> 
>
https://codereview.appspot.com/95550047/diff/60001/cpp/test/preload_supplier_...
> cpp/test/preload_supplier_test.cc:108: unknown_address.administrative_area =
> "ZZ";
> And it'd be the same if we loaded rules for US/CA, and then asked for
> US/CA/Mountain View, right?

Yes, US/CA/Mountain View should return NULL.

[Rouslan Solomakhin, 2014-05-23 08:34:24]

Committed patchset #4 manually as r243 (presubmit successful).