Remove juju-core dependencies from filetesting.

Remove juju-core dependencies from filetesting.

In order to move the testing/filetesting package to
Github, we need to remove its juju-core dependencies.

Moved the IsNotExist function from utils to filetesting.
If required, the function can be restored in the original
place once we also have utils in its own project.

https://code.launchpad.net/~frankban/juju-core/filetesting-deps/+merge/220660

(do not edit description out of merge proposal)

[frankban, 2014-05-22 14:21:29]

Please take a look.

[rog, 2014-05-22 16:49:51]

LGTM modulo a few considerations below.

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix.go
File testing/filetesting/file_unix.go (right):

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix....
testing/filetesting/file_unix.go:1: // Copyright 2014 Canonical Ltd.
perhaps this file could be called "isnotexist_unix.go" as that's what it's for.

?

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix....
testing/filetesting/file_unix.go:19: func IsNotExist(err error) bool {
Is it actually worth exporting this function now? I don't want people to import
testing/filetesting for the sake of it - I think it could probably be internal
to filetesting. We can factor it out if it's needed somewhere else.

https://codereview.appspot.com/95550046/diff/1/utils/file_unix.go
File utils/file_unix.go (right):

https://codereview.appspot.com/95550046/diff/1/utils/file_unix.go#newcode1
utils/file_unix.go:1: // Copyright 2013, 2014 Canonical Ltd.
I don't think we need to update copyright notices every time we change a file
(even more so when we're just deleting code)

https://codereview.appspot.com/95550046/diff/1/utils/file_windows.go
File utils/file_windows.go (right):

https://codereview.appspot.com/95550046/diff/1/utils/file_windows.go#newcode1
utils/file_windows.go:1: // Copyright 2013, 2014 Canonical Ltd.
ditto re copyright.

[frankban, 2014-05-22 17:12:59]

Please take a look.

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix.go
File testing/filetesting/file_unix.go (right):

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix....
testing/filetesting/file_unix.go:1: // Copyright 2014 Canonical Ltd.
On 2014/05/22 16:49:51, rog wrote:
> perhaps this file could be called "isnotexist_unix.go" as that's what it's
for.
> 
> ?

Done.

https://codereview.appspot.com/95550046/diff/1/testing/filetesting/file_unix....
testing/filetesting/file_unix.go:19: func IsNotExist(err error) bool {
On 2014/05/22 16:49:51, rog wrote:
> Is it actually worth exporting this function now? I don't want people to
import
> testing/filetesting for the sake of it - I think it could probably be internal
> to filetesting. We can factor it out if it's needed somewhere else.

Done.

https://codereview.appspot.com/95550046/diff/1/utils/file_unix.go
File utils/file_unix.go (right):

https://codereview.appspot.com/95550046/diff/1/utils/file_unix.go#newcode1
utils/file_unix.go:1: // Copyright 2013, 2014 Canonical Ltd.
On 2014/05/22 16:49:51, rog wrote:
> I don't think we need to update copyright notices every time we change a file
> (even more so when we're just deleting code)

Done.

https://codereview.appspot.com/95550046/diff/1/utils/file_windows.go
File utils/file_windows.go (right):

https://codereview.appspot.com/95550046/diff/1/utils/file_windows.go#newcode1
utils/file_windows.go:1: // Copyright 2013, 2014 Canonical Ltd.
On 2014/05/22 16:49:51, rog wrote:
> ditto re copyright.

Done.

[rog, 2014-05-22 17:16:36]

still LGTM

https://codereview.appspot.com/95550046/diff/20001/testing/filetesting/isnote...
File testing/filetesting/isnotexist_test.go (right):

https://codereview.appspot.com/95550046/diff/20001/testing/filetesting/isnote...
testing/filetesting/isnotexist_test.go:15: type fileSuite struct{}
isNotExistSuite ?

[frankban, 2014-05-22 17:22:15]

Please take a look.

https://codereview.appspot.com/95550046/diff/20001/testing/filetesting/isnote...
File testing/filetesting/isnotexist_test.go (right):

https://codereview.appspot.com/95550046/diff/20001/testing/filetesting/isnote...
testing/filetesting/isnotexist_test.go:15: type fileSuite struct{}
On 2014/05/22 17:16:36, rog wrote:
> isNotExistSuite ?

Ah! Right. Thanks for the review!