Issue 95480043: Make send_message() with end=False generate frame when permessage-deflate is enabled

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95480043: Make send_message() with end=False generate frame when permessage-deflate is enabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by tyoshino (chromium.org)

Modified:
11 years, 11 months ago

Reviewers:
Yutaka Hirano

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make send_message() with end=False generate frame when permessage-deflate is enabled Currently, data passed by send_message() with end=False is buffered inside the deflater object. To be consistent with send_message()'s behavior when permessage-deflate is not enabled, make it flush given data. This CL also adds tests to check how permessage-deflate's implementation generates fragments. R=yhirano@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=799

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -30 lines)			Patch
M	src/mod_pywebsocket/extensions.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mod_pywebsocket/util.py	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/test/test_msgutil.py	View		2 chunks	+69 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tyoshino (chromium.org)

11 years, 11 months ago (2014-05-21 02:01:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r799 (presubmit successful).

Expand All Messages | Collapse All Messages