Issue 954041: code review 954041: 6l, 8l: include ELF header in PT_LOAD mapping for text ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 954041: code review 954041: 6l, 8l: include ELF header in PT_LOAD mapping for text ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

6l, 8l: include ELF header in PT_LOAD mapping for text segment Due to page boundary rounding, the header would have been loaded as part of the text segment already, but this change placates the "paxctl" tool on so-called hardened Linux distributions (as if normal distributions weren't already hard enough to use).

Patch Set 1 #

Patch Set 2 : code review 954041: 6l, 8l: include ELF header in PT_LOAD mapping for text ... #

Patch Set 3 : code review 954041: 6l, 8l: include ELF header in PT_LOAD mapping for text ... #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/cmd/6l/asm.c	View		1 chunk	+5 lines, -5 lines	0 comments	Download
	M	src/cmd/8l/asm.c	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-21 00:38:53 UTC) #1

rsc

14 years, 11 months ago (2010-04-21 03:39:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3acf28684918 ***

6l, 8l: include ELF header in PT_LOAD mapping for text segment

Due to page boundary rounding, the header would have
been loaded as part of the text segment already, but this
change placates the "paxctl" tool on so-called hardened
Linux distributions (as if normal distributions weren't already
hard enough to use).

R=r
CC=golang-dev
http://codereview.appspot.com/954041

Expand All Messages | Collapse All Messages