Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 9517046: Inherited methods for node lists; more distinct toString()s. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
MarkM, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Give node list types toString methods. * Give proxy handlers toString methods. * When rebuilding the node-list prototype chain, copy old prototype properties over so that node list types can have inherited methods; used for toString. Not yet used for item() because those close over their data source. @r5416

Patch Set 1 #

Patch Set 2 : Inherited methods for node lists; more distinct toString()s. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -17 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 18 chunks +69 lines, -14 lines 2 comments Download
M src/com/google/caja/ses/startSES.js View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 9 months ago (2013-05-20 22:53:45 UTC) #1
kpreid2
* Give node list types toString methods. * Give proxy handlers toString methods. * When ...
12 years, 9 months ago (2013-05-20 23:00:44 UTC) #2
ihab.awad
lgtm++ https://codereview.appspot.com/9517046/diff/3001/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/9517046/diff/3001/src/com/google/caja/plugin/domado.js#newcode2857 src/com/google/caja/plugin/domado.js:2857: function finishArrayLikeClass(constructor) { Can you pull finishArrayLikeClass() into ...
12 years, 9 months ago (2013-05-21 19:21:20 UTC) #3
kpreid2
https://codereview.appspot.com/9517046/diff/3001/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/9517046/diff/3001/src/com/google/caja/plugin/domado.js#newcode2857 src/com/google/caja/plugin/domado.js:2857: function finishArrayLikeClass(constructor) { On 2013/05/21 19:21:20, ihab.awad wrote: > ...
12 years, 9 months ago (2013-05-21 19:47:20 UTC) #4
MarkM
12 years, 9 months ago (2013-05-21 20:31:09 UTC) #5
Message was sent while issue was closed.
ses/* parts LGTM.
Please remember to include me as a secondary reviewer on CLs with any ses/*
components.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b