Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 95079: domita_test fixes for IE (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by felix8a
Modified:
16 years, 10 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. domita_test counting was slightly off. this change fixes the invariant count==(pass+fail). it's still more fragile than I like. I have a change in mind to make it less fragile, but the change will be large and invasive, so not right now. also, it's still missing accounting of the async assertions. 2. domita_test often crashes my ie6 and ie7. it's not a reliable crash. sometimes with no code changes, it will mysteriously work. this would bother me more, but I've only seen it happen with domita_test, not with anything else. it seems to be something about the ScriptLoad test. when I disable that test, I stop seeing IE crashes. I'll open a bug to narrow this down more. 3. domita_test is sensitive to browser quirks in formatting of rgb color values. this change normalizes the color tests. 4. after appling this change and the html-emitter change http://codereview.appspot.com/89076/show domita_test has 3 fails on ie8, +1 on ie7, +2 on ie6. I'll open a bug to describe those.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -66 lines) Patch
M tests/com/google/caja/plugin/domita_test.html View 5 chunks +10 lines, -11 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 12 chunks +41 lines, -55 lines 2 comments Download

Messages

Total messages: 3
felix8a
16 years, 10 months ago (2009-07-19 21:46:53 UTC) #1
ihab.awad
LGTM++ http://codereview.appspot.com/95079/diff/1/3 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/95079/diff/1/3#newcode2382 Line 2382: // runs without focusing the browser, so ...
16 years, 10 months ago (2009-07-20 23:16:06 UTC) #2
felix8a
16 years, 10 months ago (2009-07-21 22:06:59 UTC) #3
@r3600

http://codereview.appspot.com/95079/diff/1/3
File tests/com/google/caja/plugin/domita_test_untrusted.html (right):

http://codereview.appspot.com/95079/diff/1/3#newcode2382
Line 2382: // runs without focusing the browser, so onfocus never fires.
On 2009/07/20 23:16:06, ihab.awad wrote:
> I assume you removed testOnFocus / testOnBlur because it is essentially dead
> code. However, perhaps having commented-out tests in there is better than just
a
> TODO that can be easily missed, and at least serves as documentation for the
> sort of thing that needs to be tested?

I deleted it because the thing it's testing is already
covered by the testOnReset case below, and an actual
test of onfocus/onblur would look very different, so
I didn't see any value in keeping the redundant test.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b